559747 - a11y mochitest for <input type="search">

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

It's going to be autocomplete text field, we should expose it with COMBOBOX_ROLE.

Comment 1

[alexander :surkov (:asurkov)]

Autocomplete stuffs should be covered by bug 559766

Comment 2

[alexander :surkov (:asurkov)]

It should be exposed as text entry with autocomplete state now. So all we should do is to add mochitest (add to states/test_inputs at autocomplete testing part and to tree/test_txtctrl.html).

Comment 3

[Mark Capella [:capella]]

Attachment: Patch (v1)

This patch looks like the one we just did for Bug 559759 ... let me know if there's something more to it that I'm missing and I'll address it ...

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 618404 [details] [diff] [review]
Patch (v1)

Review of attachment 618404 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/mochitest/states/test_inputs.html
@@ +164,5 @@
> +  <a target="_blank"
> +     href="https://bugzilla.mozilla.org/show_bug.cgi?id=559747"
> +     title="Add a11y mochitests for input type=search">
> +    Mozilla Bug 559747
> +  </a>

in general you don't need a bug reference when the bug is about adding a mochitest

Comment 5

[Marco Zehe (:MarcoZ)]

Comment on attachment 618404 [details] [diff] [review]
Patch (v1)

r=me, thanks!

Note that in the long term, I'd like to see us use a new internal role for search inputs. Both mobile operating systems and Mac OS X know about this special input, and we should expose it correctly. But that should be done in a separate bug, since what we have now works on a basic level, and covering it with these tests here is perfect. Thanks for the patch!

Comment 6

[alexander :surkov (:asurkov)]

Marco, please file a bug on it. You can make it a good first bug.

Comment 7

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/543a22b27d8e

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/543a22b27d8e