Closed
Bug 559800
Opened 14 years ago
Closed 14 years ago
Extensions.sqlite doesn't get properly recreated if it is deleted
Categories
(Toolkit :: Add-ons Manager, defect, P1)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla1.9.3a5
People
(Reporter: mossop, Assigned: mossop)
References
Details
(Whiteboard: [rewrite])
Attachments
(1 file)
|
3.20 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
If extensions.sqlite is deleted from the profile but the preference extensions.databaseSchema still has a valid schema value then the database doesn't get recreated properly.
|
Assignee | |
Comment 1•14 years ago
|
||
Explicitly recreates the schema when the database isn't there.
Attachment #439514 -
Flags: review?(robert.bugzilla)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Landed on the project branch: http://hg.mozilla.org/projects/addonsmgr/rev/793fa0f87f61
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr][needs-review]
|
||
Comment 3•14 years ago
|
||
Dave, we cover everything with the automated test, right?
Flags: in-testsuite+
Flags: in-litmus-
|
|
Assignee | |
Comment 4•14 years ago
|
||
Sorry yes I don't think there is any need for manual testing here.
|
|
Assignee | |
Comment 5•14 years ago
|
||
The unit test is failing on linux, I know why and it isn't a problem with the fix, just not quite sure how to fix it yet
Flags: in-testsuite+ → in-testsuite?
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite][fixed-in-addonsmgr]
|
||
Comment 6•14 years ago
|
||
Comment on attachment 439514 [details] [diff] [review] patch rev 1 Makes sense
Attachment #439514 -
Flags: review?(robert.bugzilla) → review+
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite][fixed-in-addonsmgr][needs-landing]
|
|
Assignee | |
Comment 7•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/220a671d23d2
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-landing] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
|
|
||
Comment 8•14 years ago
|
||
Verified fixed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100517 Minefield/3.7a5pre (.NET CLR 3.5.30729) ID:20100517035949 The check-in contained an automated test. Flipping the flag accordingly.
Status: RESOLVED → VERIFIED
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•