Closed
Bug 560010
Opened 14 years ago
Closed 14 years ago
Remove names from getters and setters in mail/ and mailnews/
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.1b2
People
(Reporter: rain1, Assigned: rain1)
References
()
Details
Attachments
(1 file)
|
22.18 KB,
patch
|
asuth
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
Bug 517580 seems to have removed named getters using the get syntax from SpiderMonkey. We should get rid of them as well.
|
Assignee | |
Comment 1•14 years ago
|
||
(and setters too)
Summary: Remove named getters from mail/ and mailnews/ → Remove named getters and setters from mail/ and mailnews/
|
|
Assignee | |
Comment 2•14 years ago
|
||
The URL I linked to isn't comprehensive, but the two regexes "^ *(get|set) +[A-Za-z_]+ +[A-Za-z_]+" (single line) and "^ *(get|set) +[A-Za-z_]+ *$" (multi-line definition) should cover all the cases we have. I've verified with egrep that those two regexes don't match anything else in either mail/ or mailnews/.
Assignee: nobody → sid.bugzilla
Status: NEW → ASSIGNED
Attachment #439681 -
Flags: superreview?(bienvenu)
Attachment #439681 -
Flags: review?(bugmail)
|
||
Updated•14 years ago
|
Attachment #439681 -
Flags: review?(bugmail) → review+
|
||
Updated•14 years ago
|
Attachment #439681 -
Flags: superreview?(bienvenu) → superreview+
|
|
Assignee | |
Comment 3•14 years ago
|
||
[clarified the summary a little] http://hg.mozilla.org/comm-central/rev/2897f71b5ce2
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Summary: Remove named getters and setters from mail/ and mailnews/ → Remove names from getters and setters in mail/ and mailnews/
Target Milestone: --- → Thunderbird 3.1b2
You need to log in
before you can comment on or make changes to this bug.
Description
•