Closed
Bug 560139
Opened 14 years ago
Closed 14 years ago
jsdStackFrame::Eval leaks estate when failing to use ContextStack
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
862 bytes,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
1952 jsdStackFrame::Eval (const nsAString &bytes, const nsACString &fileName,
1972 estate = JS_SaveExceptionState (cx);
1976 nsCOMPtr<nsIJSContextStack> stack = do_GetService("@mozilla.org/js/xpc/ContextStack;1", &rv);
1977 if (NS_FAILED(rv))
1978 return rv;
1979 rv = stack->Push(cx);
1980 if (NS_FAILED(rv))
1981 return rv;
1995 JS_RestoreExceptionState (cx, estate);
|
||
Comment 2•14 years ago
|
||
Comment on attachment 439862 [details] [diff] [review] patch http://hg.mozilla.org/tracemonkey/rev/9f57684dd42a
Attachment #439862 -
Flags: review?(jorendorff) → review+
|
|
||
Updated•14 years ago
|
Whiteboard: fixed-in-tracemonkey
|
||
Comment 3•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/9f57684dd42a
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Component: JavaScript Debugging/Profiling APIs → JavaScript Engine
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•