560261 - _DOMElement assertion on livemarks update

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak]]

sounds like i get a bunch of assertions when a livemark updates, not sure what's up, investigating.

Comment 1

[Marco Bonardo [:mak]]

i think i figured out this happens when there is no active window, since livemarks update can happen when there is no FX window active, we hit the assertion. I can reproduce this asking a livemark to update and immediately switching to another unrelated window.
I think links between PUIU and window are too lazy, so i'll try to extract the window/document from params.

Comment 2

[Marco Bonardo [:mak]]

Attachment: patch v1.0

This should be good, since these are tasks that could happen in background, it's common we could not have an activeWindow. I just get the document from the popup we are building then, for backwards compat with add-ons i use the top browser window otherwise.

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 440001 [details] [diff] [review]
patch v1.0

r=sdwilsh

Comment 4

[Axel Hecht]

FYI, I won't use the nightlies until this is landed.

Comment 5

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/2e1b0e131c49

Comment 6

[Marco Bonardo [:mak]]

to reproduce the bug, right click on a livemark, ask for a reload and immediately switch to another application (not a firefox window), then wait some second.

Comment 7

[Paul [pwd]]

Does this also cover the message I'm receiving "assert mode must have dom element set"?

Comment 8

[Marco Bonardo [:mak]]

(In reply to comment #7)
> Does this also cover the message I'm receiving "assert mode must have dom
> element set"?

it's about it.