560524 - [gd] Search engine setup for Firefox 3.6 for Scottish Gaelic.

Status: VERIFIED FIXED

(Mozilla Localizations :: gd / Scottish Gaelic, defect)

Description

[Axel Hecht [:Pike]]

We want to ship Firefox 3.6 a good list of search engines for Scottish Gaelic. 

We're going to work towards this in three phases. First, the localization team and Stas (Stas Malolepszy) will look at the market for the language and come up with a good set of search providers. Michael, Kevin, we'll need your input on this, the guidelines for making recommendations are on <https://wiki.mozilla.org/L10n:Firefox/Productization>. 

For en-US, we currently use this set, to which we can fall back in the case of lacking localized alternatives:
Google, Yahoo, Amazon, Answers, CC, eBay, Wikipedia

After we decided on a particular search engine, Stas will contact the owner and ask for permission, and for specifics like proper search flags. Michael, Kevin, we'll likely need your help to at least get the contact information.

Once we have a specification on what the searchengines for Scottish Gaelic should look like, the localization team and Stas will work on an implementation on that. This should happen by the localization team creating and attaching patches for the desired changes, and requesting review from Stas. After a successful review, the localization team will land them.

Please don't commit any modifications in browser/searchplugins to the hg repository without a patch reviewed by Stas, Axel or someone else appointed by Stas or SethB. The data here is sensitive to users and our search partners, thus the extra care here.

Comment 1

[Michael Bauer]

There's not much out there. My personal inclination would be to use whatever the EN-GB localisation uses except for Google (which has a Gaelic interface) and perhaps the Gaelic Wikipedia. Not sure about the Gaelic Wiki though as it's so small. Kevin, does the Irish FF link to the Irish Wiki?

Comment 2

[Kevin Scannell]

(In reply to comment #1)
> There's not much out there. My personal inclination would be to use whatever
> the EN-GB localisation uses except for Google (which has a Gaelic interface)
> and perhaps the Gaelic Wikipedia. Not sure about the Gaelic Wiki though as it's
> so small. Kevin, does the Irish FF link to the Irish Wiki?


Yes, we use the Irish wikipedia and have gotten positive feedback on that from users.

Comment 3

[Michael Bauer]

Ok, let's use http://gd.wikipedia.org and hope for the best...

Comment 4

[Seth Bindernagel]

OK, picking this back up after some downtime, sorry about that.

Michael, just an idea for some further consideration, are there any other search engines of interest that might be good for our Scottish users?  Can we include dictionaries or educational websites about Scottish Gaelic?

Comment 5

[Michael Bauer]

Hey, it's ok, I know all about delays, I've been putting of the publishing date of my Gaelic pronunciation book for more than 4 yrs now ;)

Didn't realise educational links could also feature. There's a few that I could propose:
http://www.faclair.com Am Faclair Beag
http://www2.smo.uhi.ac.uk/gaidhlig/faclair/sbg/lorg.php An Stòr-dàta Briathrachais
These are the two main online dictionary resources for Gaelic currently available.

http://www.bbc.co.uk/alba/ BBC Alba
Would also be a good site. It not only leads to the Gaelic news output but also doubles up as a portal to a lot of educational stuff from the Learners' Letter to Bitesize

http://www.akerbeltz.org/ Akerbeltz
I know, my own, but it's still the only place offering learners a lot of info on advanced grammar and phonology issues.

http://www.foramnagaidhlig.net Fòram na Gàidhlig
A Gaelic (well, sort of the only active...) forum for learners and fluent speakers covering a wide range of topics, dealing with related news, support for learners and off-topic (in the sense of not about Gaelic) debates in Gaelic.

http://www.ambaile.org.uk/ Am Baile
A bilingual database of Highland history and culture.

I realise some of the above may not be appropriate - I'll leave that to your good judgement - I just put down all the good ones known to me.

In case you meant educational in the sense of where to learn the language, I can suggest the following three places:
http://www.smo.uhi.ac.uk/index_gd.html Sabhal Mòr Ostaig
The only higher education institution teaching in Gaelic, often called the "Gaelic College".
http://www.cli.org.uk/ CLÌ Gàidhlig
The Gaelic learners' Association, a good staring point for anyone looking for courses
http://www.stow.ac.uk/ Stow College
The only college south of the Highlands that offers full-time immersion courses.

Any of these any good?

Comment 6

[Seth Bindernagel]

Keep in mind that we'll need 2 search engines for each of the following:

1)  General Purpose (Google, etc)
2)  e-Commerce (Amazon)
3)  Specific interest (Wikipedia, etc)

(In reply to comment #5)
> There's a few that I could
> propose:
> http://www.faclair.com Am Faclair Beag
> http://www2.smo.uhi.ac.uk/gaidhlig/faclair/sbg/lorg.php An Stòr-dàta
> Briathrachais
> These are the two main online dictionary resources for Gaelic currently
> available.

Which of these two do you prefer?


> http://www.bbc.co.uk/alba/ BBC Alba
> Would also be a good site. It not only leads to the Gaelic news output but also
> doubles up as a portal to a lot of educational stuff from the Learners' Letter
> to Bitesize

Could be a good one, let's add it under the "Specific Interest" category

> http://www.akerbeltz.org/ Akerbeltz
> I know, my own, but it's still the only place offering learners a lot of info
> on advanced grammar and phonology issues.

Might be too specific or "grammar-technical" for this purpose.
 
> http://www.foramnagaidhlig.net Fòram na Gàidhlig
> A Gaelic (well, sort of the only active...) forum for learners and fluent
> speakers covering a wide range of topics, dealing with related news, support
> for learners and off-topic (in the sense of not about Gaelic) debates in
> Gaelic.

Interesting, I like this one.  Perhaps we put it in the Specific Interest section.

> 
> http://www.ambaile.org.uk/ Am Baile
> A bilingual database of Highland history and culture.

We can consider it, but I think this would not be used in place of some of the others.

So, here is the list taking shape:

1)  General Purpose:  Google + one more suggestion
2)  e-Commerce: Any suggestions?
3)  Specific interest (Wikipedia, BBC Alba, Foramnagaidhlig)

Comment 7

[Michael Bauer]

> Which of these two do you prefer?
Am Faclair Beag (http://www.faclair.com). As yet, it has fewer technical terminology but better info on grammar and usage. Plus it's continually being expanded.

> > http://www.bbc.co.uk/alba/ BBC Alba
> Could be a good one, let's add it under the "Specific Interest" category
Ok

> > http://www.akerbeltz.org/ Akerbeltz
> Might be too specific or "grammar-technical" for this purpose.
Ok

> > http://www.foramnagaidhlig.net Fòram na Gàidhlig
> Interesting, I like this one.  Perhaps we put it in the Specific Interest
> section.
Ok

> > http://www.ambaile.org.uk/ Am Baile
> > A bilingual database of Highland history and culture.
> We can consider it, but I think this would not be used in place of some of the
> others.
Yes, it is a bit specific.
 
> So, here is the list taking shape:
> 
> 1)  General Purpose:  Google + one more suggestion
> 2)  e-Commerce: Any suggestions?
> 3)  Specific interest (Wikipedia, BBC Alba, Foramnagaidhlig)

1) Google (the Gaelic interface). The second is more tricky. We can either go for something widely used like Yahoo or an open source engine that could (at least in theory) be localised. Are there any Fx localisations that offer non-mainstream search engines?

2) There's nothing specifically Gaelic. Something like amazon.co.uk should do.

3) Agreed.

Which batch would the dict go under?

Comment 8

[Seth Bindernagel]

Typically, we only go for 6 search engines.  So, we can either not include Yahoo, or go with 7 and include Yahoo.  Because the gd user base will be relatively special (aka those specifically seeking out the gd version), I don't think having 7 makes too much of a difference, especially since we are adding three to four Gaelic specific search engines.  

How about this for the final list?

1)  General Purpose -- Google, Yahoo
2)  e-Commerce -- Amazon.co.UK
3)  Specific interest -- Wikipedia, BBC Alba, Foramnagaidhlig, Am Faclair Beag

Comment 9

[Michael Bauer]

> How about this for the final list?
> 
> 1)  General Purpose -- Google, Yahoo
> 2)  e-Commerce -- Amazon.co.UK
> 3)  Specific interest -- Wikipedia, BBC Alba, Foramnagaidhlig, Am Faclair Beag

Happy with the list. Just one question -

> think having 7 makes too much of a difference, especially since we are adding
> three to four Gaelic specific search engines.  
In what sense will they be Gaelic-specific (except for the Gaelic Google interface)? I'm not aware of any other search engine offering anything Gaelic specific.

Comment 10

[Michael Bauer]

Ok, Kevin helped me locate the files in question - the txt would be easy enough to amend (and attach here?) but am I supposed to create the xml files from scratch as well?

Comment 11

[Seth Bindernagel]

For Google, Yahoo!, Amazon.co.uk, and Wikipedia you should create the xml files and attach them here as a patch.  We'll review those once you attach and flag me (:sethb) for a review.

We will need to email Foramnagaidhlig and Am Faclair Beag to get permission and ask for specific search parameters that they want us to use for the XML file.

Lastly, we should look specifically at the BBC Alba.  We probably have a BBC search engine example somewhere we can reference, but we should also try to get a confirmation that we can ship this one.  Let me ask Stas for an opinion.  

Michael, can you find me some type of business-development contacts for Foramnagaidhlig and Am Faclair Beag?  I can take a look, but you might be able to find them more easily since you read the language.

Comment 12

[Michael Bauer]

Sure, I'll post contacts once I've established who they want this to go through. Do you want me to find some contact at the BBC Alba end too? I know some people on the team.

Any help page on how to do the XML?

Comment 13

[Seth Bindernagel]

(In reply to comment #12)
> Sure, I'll post contacts once I've established who they want this to go
> through. Do you want me to find some contact at the BBC Alba end too? I know
> some people on the team.

Yes please.  In fact, I will email you a template to use.  You can do outreach to BBC Alba, Foramnagaidhlig, and Am Faclair Beag, copying me.  We'll need to ask for specific parameters, and I can help respond to that if they have questions.  

Here is an example of how specific XML search parameters will appear:

https://wiki.mozilla.org/L10n:Toolbox/Creating_a_search_plugin#Special_parameters_requested_by_the_provider

> Any help page on how to do the XML?

This should help you:

https://wiki.mozilla.org/L10n:Toolbox/Creating_a_search_plugin

Comment 14

[Seth Bindernagel]

Attachment: Faclair Baeg Search Plugin

Michael, let's discuss this XML file that will be the search plugin for Faclair Baeg.  They never sent me any additional parameters to identify any searches from the Firefox user agent.  If they do, that will be an easy change for us to make.

You should test this patch and if it works for you, you should copy the XML file in the /browser/searchplugins folder of your working copy of Scottish Gaelic

Comment 15

[Seth Bindernagel]

Attachment: Fòram na Gàidhlig Search Plugin

Comment 16

[Seth Bindernagel]

For Google, Yahoo, and Amazon, you can copy the the XML files you find in Irish Gaelic's /browser/searchplugins folder since you want to keep those the same.

Is there a Scottish Gaelic version of Wikipedia?  I had a hard time finding it.  We can create the Wikipedia plugin pretty quickly, too, if you can link it to me.

For BBC Alba, were you going to contact someone there?  Otherwise, we can try to create it.  We point in one way or another to BBC from many versions of Firefox, but it would still be good to get a confirmation.

Comment 17

[Seth Bindernagel]

(In reply to comment #14)
> Created an attachment (id=451178) [details]
> Faclair Baeg Search Plugin

By the way, is it "Faclair Baeg" or "Am Faclair Baeg"?  We might need to make the change to the XML file.

Comment 18

[Michael Bauer]

Wikipedia - there is, it was posted in the other string (http://gd.wikipedia.org)

I'll test the xmls you posted tomorrow evening (it's 2am and I'm about to fall over), thanks!

Don't think that Google/Yahoo/Amazon need changing as I'm 99% they're the same as English but I'll check.

I did contact BBC Alba, still waiting for response, I'll chase that tomorrow.

It's "Am Faclair Beag" (note the spelling of the vowels in "Beag")

Comment 19

[Staś Małolepszy :stas]

(In reply to comment #16)
> For Google, Yahoo, and Amazon, you can copy the the XML files you find in Irish
> Gaelic's /browser/searchplugins folder since you want to keep those the same.

A technical detail to add here: we should copy the Yahoo and Amazon plugins from ga-IE (or en-GB), but not Google. We need separate files for Yahoo and Amazon so that we point users to the British versions of these sites. For Google however, it's better to rely on Google's language/geo detection. We can thus use the default plugin as found in en-US. Consequently, we only need to make sure list.txt lists `google`--and if it does, the plugin will be copied over from en-US automatically during the build process.

Comment 20

[Seth Bindernagel]

Attachment: wikipedia-gd

Comment 21

[Seth Bindernagel]

Attachment: Small updates to Am Faclair Beag

Comment 22

[Michael Bauer]

Ok, I have downloaded the attachments, emptied the browser/searchplugins folder bar the Google.xml and copied the other searchplugins from the Irish folder (amazon-en-GB, answers, creativecommons, ebay-en-GB, yahoo-en-GB).

Before I upload this, should I also changed the list.txt and if so, how do the names work? Is it just the URL spelled out (dot instead of .)?

Comment 23

[Seth Bindernagel]

(In reply to comment #22)
> Ok, I have downloaded the attachments, emptied the browser/searchplugins folder
> bar the Google.xml and copied the other searchplugins from the Irish folder
> (amazon-en-GB, answers, creativecommons, ebay-en-GB, yahoo-en-GB).
> 
> Before I upload this, should I also changed the list.txt and if so, how do the
> names work? Is it just the URL spelled out (dot instead of .)?

That's right.  Just like en-GB.  Or, ga-IE is a another good reference point for you:

http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/ga-IE/file/06fa4fe0c698/browser/searchplugins/list.txt

Comment 24

[Michael Bauer]

So mine should be:

googledotcomukdotyahoodotcomamazondotcodotukebaydotcodotukanswersdotcomcreativecommonsdotorgfaclairdotcomgddotwikipediadotorg

I just want to make sure I get this right, sorry if I seem dense!

Comment 25

[Seth Bindernagel]

The search plugins are going to be the title of each file preceding the .xml ending.  It will probably look like this, but it depends on how you have named the file.

google
yahoo-en-GB
amazon-en-GB
faclair-baeg
foran-na-gaidhlig
wikipedia-gd
bbc-alba-en-GB

Don't include any special characters in the .xml file names.

Comment 26

[Michael Bauer]

ok, done and pushed. Except for the BBC one of course.

Comment 27

[Staś Małolepszy :stas]

Hi Michael, I think that you might have forgotten to `hg add` the xmls from this bug in your commit. I can only see changes to list.txt in http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/gd/rev/d6e30f5013c2.

Also, according to http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/gd/diff/d6e30f5013c2/browser/searchplugins/list.txt list.txt now has 9 engines, while I think the plan was to have 7 (with bbc alba). Should we remove ebay, answers and creativecommons?

To catch such issues early, it's usually a good idea to attach a patch and have it review in bugzilla before pushing. Once you make your changes but before you commit/push, just issue `hg diff > changes.diff` and attach changes.diff in the bug.

Thanks.

Comment 28

[Michael Bauer]

Ok, I'll remove ebay, answers, commons (I was just working off the Irish late last night, sorry).

I'm less than a novice with these commands, essentially I have a sheet of instructions Kevin helped me with so I can commit/push, I didn't realise I have to do something special with the xmls. Sorry about that. Again ;)

I normally go
hg diff .
hg commit -m "..." .
hg push

At which point in this process (if related) do I run hg add and what does the line have to look like exactly?

Comment 29

[Staś Małolepszy :stas]

(In reply to comment #28)
> I'm less than a novice with these commands, essentially I have a sheet of
> instructions Kevin helped me with so I can commit/push, I didn't realise I have
> to do something special with the xmls. Sorry about that. Again ;)

Nah, no worries. We're here to help :)

> I normally go
> hg diff .
> hg commit -m "..." .
> hg push
> 
> At which point in this process (if related) do I run hg add and what does the
> line have to look like exactly?

I'd recommend the following suite of commands:
1. hg status
   This will output all changed files, as well a "?" next to files that are not yet tracked by hg (these need to be added manually via an `hg add`.
2. hg add
   This will add all new files (for example the search plugins you copied). You can also try running `hg addremove` instead (see `hg help addremove` for details)
3. hg diff 
4. hg commit -m "..."
5. hg push

For changes to productization bits (search engins, protocol handlers, news readers), it's best to stop after step 3, attach the output of `hg diff` to the relevant bug and wait for a review+ before moving on to steps 4 and 5.

HTH :)
-stas

Comment 30

[Michael Bauer]

Hm I did that and there's something that doesn't look right. I followed the above to step 3 but it lists files that don't seem to be related to the search plugins at all and the final list (on Cygwin) is too long so I can't copy it all.

I have added an attachment that at the very bottom of the document has the output I get for hg status and then what I get at step 3 for hg diff (all that i can copy).

Comment 31

[Michael Bauer]

Attachment: Search plugins - hg diff output

Comment 32

[Michael Bauer]

Nightly releases for gd seem to be stuck on the 15 June - is it possible that that has something to do with me running the above command line up to hg diff but not pushing it?

Comment 33

[Axel Hecht [:Pike]]

Yes, see http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n-gd&hours=24 for the logs of the actual builds.

Comment 34

[Michael Bauer]

So is the above ok to push? I just wasn't sure because it looked like there were things in the hg diff not related to the search plugins.

Comment 35

[Axel Hecht [:Pike]]

Comment on attachment 451568 [details]
Search plugins - hg diff output

r- on this. The toolkit files seem to be only good going forward on central, we're not there yet.

The mobile files seem to be OK. Do we have a bug to actually start building fennec?

Here's a good path forward:

hg rm browser/searchplugins/google.xml

You're not supposed to have that file anyway, and the build picks up the en-US one, whether you have it or not.

hg ci -m"bug 560524, add missing search plugins" browser/searchplugins

The important piece here is to actually add the path. Bad Stas should have made you hg add with a path argument only to begin with :-)

back up, and hg rm the other files for when we actually work on fx4 or mobile.

Comment 36

[Michael Bauer]

No we don't have a bug for Fennec yet.

What's r-?

I ran hg rm browser/searchplugins/google.xml but it says because it has been marked for add I cannot remove and to use -f for force remove but then says command not found.

I then simply removed the google.xml manually and ran the hg status and hg ci -m"bug 560524, add missing search plugins" browser/searchplugins you suggested which came up clean in the sense that the google.xml wasn't listed anymore. But when I try to hg rm browser/chrome/browser/taskbar.properties it comes up with the same problem.

Is there a way of purging what it is holding in its "hg add" memory and starting from scratch? I presume if I start with hg ci -m"bug 560524, add missing search plugins" browser/searchplugins from an empty hg add memory it won't introduce the unwanted bits?

Comment 37

[Axel Hecht [:Pike]]

just hg rm -f foo.bar if hg asks you to, that's just a warning which, if it's what you want, is safe to override with -f.

Comment 38

[Michael Bauer]

>.< 

I have now successfully removed all the paths that we don't want. However, now it tells me (when I run hg ci -m"bug 560524, add missing search plugins" browser/searchplugins) 

abort: browser/searchplugins: no match under directory!

But the directory is there...

Comment 39

[Axel Hecht [:Pike]]

can you give the output of

pwd
hg stat

Comment 40

[Axel Hecht [:Pike]]

PS: if you can join on irc, that's great for debugging stuff like this quicker :-)

Comment 41

[Staś Małolepszy :stas]

Looks like the following search engines have already landed:

google
yahoo-en-GB
amazon-en-GB
faclair-baeg
foran-na-gaidhlig
wikipedia-gd

Nicely done. 

I have some second thoughts on foran-na-gaidhlig. Michael, do you think it makes a good search engine? It's with no doubt a valuable asset for the Scottish Gaelic community, and I'm all for linking to it for instance from the Getting Started page (bug 560527), but I wonder if there is a good use case for including it as a search engine. Will our user really want to _search_ the forum? If you think that yes, they will, that's fine :) Just wanted to share some thoughts.

Comment 42

[Michael Bauer]

Tricky one, that. One could argue that it could be a useful site to search for help threads for learners but I agree that it looks a little bit odd even to me, now that I've seen it in situ.

I wouldn't be averse to moving it to the getting started page.

Incidentally, any news on the request to the BBC?

Comment 43

[Seth Bindernagel]

(In reply to comment #42)
> Tricky one, that. One could argue that it could be a useful site to search for
> help threads for learners but I agree that it looks a little bit odd even to
> me, now that I've seen it in situ.
> 
> I wouldn't be averse to moving it to the getting started page.

Let's plan on moving it to the Getting Started page, and if we hear from BBC Alba, we'll add them in.
 
> Incidentally, any news on the request to the BBC?

I pinged Raemonn from BBC Alba again today.  He promised me an answer on July 7.  Let's wait a few more days. 

Once we hear from BBC Alba, we can a new patch with all the search plugins.  Rather than checking that one in straight away, can you attach the final patch for a review by me, Stas, or Axel?  With approval, you can check it in.

Comment 44

[Michael Bauer]

Hm I didn't do any of the previous search plugin patches cause I don't know how to - it was actually you who did them. Shall we just wait until word comes from the BBC and then do the lot in one go to save you time?

Comment 45

[Seth Bindernagel]

Yes, let's wait to hear from BBC and then we'll do one final patch together.  There are some quick steps you can follow here:

https://wiki.mozilla.org/L10n:Toolbox/Creating_a_search_plugin

Those are the step by step instructions on how to create a patch with all your search plugins (and with changes to list.txt).  We'll use that patch, once we have a positive review, to check into your Mozilla Hg repository for Gaelic.

Comment 46

[Michael Bauer]

Hm had a look, I think it'll be better if you do that, now that we have the BBC go-ahead and info.

Comment 47

[Seth Bindernagel]

Attachment: BBC-News (with BBC Alba) search plugin patch

Adding BBC News to gd.  With a positive review from Axel, we can check this in and we will be finished with Gaelic search plugins.

Comment 48

[Seth Bindernagel]

Attachment: BBC-News (with BBC Alba) search plugin patch

Two quick editing fixes.  Adding BBC News to gd.  With a positive review from Axel, we can check this in and we will be finished with Gaelic search plugins.

Comment 49

[Axel Hecht [:Pike]]

Comment on attachment 462055 [details] [diff] [review]
BBC-News (with BBC Alba) search plugin patch

Please keep the opensearch namespace out of the plugin, that's more confusing
than helping.
Also, convert the Url tag into one with Param children.
Did we commit to the sourceid=Mozilla-search param? Otherwise, I'd drop it. The
other params look interesting, too, are they required?

Where do we actually restrict to alba?

Also, the url redirects to
http://search.bbc.co.uk/search?scope=newsukfs&q=Firefox for a somewhat reduced
query.

Comment 50

[Seth Bindernagel]

Attachment: BBC-News (with BBC Alba) search plugin patch

And...two quick editing fixes.  :)  

Adding BBC News to gd.  With a positive review from Axel, we can check this in and we will be finished with Gaelic search plugins.

Comment 51

[Axel Hecht [:Pike]]

Comment on attachment 462057 [details] [diff] [review]
BBC-News (with BBC Alba) search plugin patch

same as attachment 462055 [details] [diff] [review]

Comment 52

[Seth Bindernagel]

Attachment: BBC-News (with BBC Alba) search plugin patch

Leaving the <ShortName> as it was suggested by Michael and approved by BBC.  

This patch should clean up a lot of the error in the former attachment.  With an r+, we can check it into the repo.

Comment 53

[Axel Hecht [:Pike]]

Comment on attachment 462078 [details] [diff] [review]
BBC-News (with BBC Alba) search plugin patch

Keep the search suggest of the original? that's the json Url element.

Also, fully Param the Url tag?

<Url type="text/html" template="http://search.bbc.co.uk/search">
  <Param name="opensearch" value="all-1"/>
  <Param name="q" value="{searchTerms}"/>
</Url>

For the suggest url, too, please.

Comment 54

[Michael Bauer]

> Where do we actually restrict to alba?

We can't, they don't have a BBC Alba specific way of searching. But if you search for a Gaelic word, you'll get Gaelic results anyway. But it's the reason for the double name because the BBC didn't want us to suggest it was BBC Alba specific.

Comment 55

[Michael Bauer]

Not sure if that's the way it would show up but it seems to say "BBC with BBC Alba" - can we change that to Gaelic "BBC ┐ BBC Alba"?

Comment 56

[Seth Bindernagel]

Attachment: BBC-News (with BBC Alba) search plugin patch

"Parameterizes" the URL strings, adds the search suggestion json, tested in Firefox.  Should be the one for us.  

With an r+ from Pike, we will check this into the gd repo.  Annotate the check in with a comment like, "Patch adding BBC Search Plugin in Bug 560524; R=pike"

Comment 57

[Axel Hecht [:Pike]]

Comment on attachment 462104 [details] [diff] [review]
BBC-News (with BBC Alba) search plugin patch

ouch, still two more nits, one of which is gonna get me killed.

http://search.bbc.co.uk/search is yielding an error page, we should make the SearchForm go somewhere else. Maybe make that turn to alba right away?

And, as much as it pains me to say this, like, hrm, could you, like, maybe, add a newline to bbc-news.xml?

Comment 58

[Seth Bindernagel]

Attachment: BBC-News (with BBC Alba) search plugin patch

"Parameterizes" the URL strings, adds the search suggestion json, makes BBB-Alba the fallback when search terms are null, and changes the name to BBC-Alba.

Tested in Firefox.    

With an r+ from Pike, we will check this into the gd repo.  Annotate the check
in with a comment like, "Patch adding BBC Search Plugin in Bug 560524; R=pike"

Comment 59

[Axel Hecht [:Pike]]

Comment on attachment 462117 [details] [diff] [review]
BBC-News (with BBC Alba) search plugin patch

ye'freakin'gods, r+

Comment 60

[Seth Bindernagel]

(In reply to comment #59)
> Comment on attachment 462117 [details] [diff] [review]
> BBC-News (with BBC Alba) search plugin patch
> 
> ye'freakin'gods, r+

Michael, this can get checked in.  I can do that or Kevin can help you. As mentioned above, when one of us checks it in be sure to annotate the check in with a comment like, "Patch adding BBC Search Plugin in Bug 560524; R=pike"

Comment 61

[Michael Bauer]

Seth, could you confirm the BBC and you are ok with "BBC ┐ BBC Alba"? Axel said we need a record of that in the bug itself rather than just email. Cheers.

Comment 62

[Staś Małolepszy :stas]

Michael: looks like you removed foram-na-gaidhlig from list.txt. Could you also run 'hg remove foram-na-gaidhlig.xml' to remove the actual search plugin file as well?

Re BBC. Seth, did you reach out to them to ask about the name change? I can do that if you didn't.

Comment 63

[Michael Bauer]

Staś, here's what Stephen Betts from the BBC said when I asked about the double barrelled name (my original query underneath); Seth should be able to confirm that's what he said as I forwarded the full email to him:

Hi Michael,
That sounds good to me.
Thanks very much for this.
Yours,
Stephen.

Subject: Re: Request for permission to include BBC Alba in a search-plugin
Very brief question - since there's no specific BBC Alba search and
given your comment below, would it be ok though to label it
BBC & BBC Alba
Many Gaelic speakers are unaware of the Gaelic content and if we just
label it BBC, they might just search for English search terms and still
completely miss the Gaelic content.
Best,
Michael

Comment 64

[Michael Bauer]

Attachment: hg diff for removing Fòram na Gàidhlig xml

Comment 65

[Axel Hecht [:Pike]]

Comment on attachment 464467 [details] [diff] [review]
hg diff for removing Fòram na Gàidhlig xml

Close. Next time, don't copy-and-paste the command line, and tick the checkbox that this is a patch. Also, set the "review" flag to "?" and the requestee to either stas or sethb.

Doing an r+ on this myself this time around.

Comment 66

[Michael Bauer]

Comment on attachment 464467 [details] [diff] [review]
hg diff for removing Fòram na Gàidhlig xml

Landed

http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/gd/rev/2aa582f3a875

Comment 67

[Seth Bindernagel]

(In reply to comment #63)
> Staś, here's what Stephen Betts from the BBC said when I asked about the double
> barrelled name (my original query underneath); Seth should be able to confirm
> that's what he said as I forwarded the full email to him:

Roger that.

Comment 68

[Staś Małolepszy :stas]

Cool. Michael, do you want to land attachment 462117 [details] [diff] [review] (bbc alba) now that the label has been confirmed?

Comment 69

[Michael Bauer]

That attachment needs to be modified before it can be landed. It currently says:
<ShortName>BBC (with BBC Alba)</ShortName>

which needs to say

<ShortName>BBC ┐ BBC Alba</ShortName>

That's what the above debate was about, no? 

I'm assuming this string: <Description>Searches BBC News</Description> does not actually appear in the interface in a way visible to the user? Or is that the tooltip that you get? In which case that needs to be "Lorg BBC ┐ BBC Alba".

Comment 70

[Staś Małolepszy :stas]

(In reply to comment #69)
> That attachment needs to be modified before it can be landed. It currently
> says:
> <ShortName>BBC (with BBC Alba)</ShortName>
> 
> which needs to say
> 
> <ShortName>BBC ┐ BBC Alba</ShortName>
> 
> That's what the above debate was about, no? 

Yes, sorry, I didn't make myself clear. Do you think you can change it to what BBC was OK with and land it? :)


> I'm assuming this string: <Description>Searches BBC News</Description> does not
> actually appear in the interface in a way visible to the user? Or is that the
> tooltip that you get? In which case that needs to be "Lorg BBC ┐ BBC Alba".

It doesn't appear in Firefox, it does in Fennec. It might someday appear in Firefox too, though. It's better to translate it, if you don't mind.

Comment 71

[Michael Bauer]

I can try but you'll have to talk me through it, all the xmls were done by you guys as (I think) we agreed that as a one-off thing, it would be quicker if you just did it. Willing to give it a go though if you prefer

Comment 72

[Seth Bindernagel]

Attachment: BBC Alba search plugin patch

Comment 73

[Michael Bauer]

Attachment: BBC Alba patch

Comment 74

[Michael Bauer]

Attachment: BBC Alba patch

Comment 75

[Seth Bindernagel]

Stas, do you know why the characters appear the way they do in both Michael's and my patches?  I don't know if it is an encoding issue.

Comment 76

[Axel Hecht [:Pike]]

Comment on attachment 464943 [details] [diff] [review]
BBC Alba patch

let's try to make the charset explicit.

Comment 77

[Axel Hecht [:Pike]]

nope, doesn't work. You gotta select utf-8 in View -> Character encoding explicitly. Which is alright, nothing wrong with the patch itself.

I wonder if that's a regression from the last bugzilla update, I recall that used to be just fine.

Comment 78

[Seth Bindernagel]

(In reply to comment #77)
> nope, doesn't work. You gotta select utf-8 in View -> Character encoding
> explicitly. Which is alright, nothing wrong with the patch itself.
> 
> I wonder if that's a regression from the last bugzilla update, I recall that
> used to be just fine.

That works for me.

Comment 79

[Michael Bauer]

Attachment: hg diff output

cleaned up repo, looking for r+ so the BBC Alba search plugin can get commited

Comment 80

[Seth Bindernagel]

Comment on attachment 465165 [details] [diff] [review]
hg diff output

I see a stray "?" just before the opening <SearchPlugin> tag.  That should not be there.  You will also need to make sure the "\ No newline at end of file" is not present in your list.txt file.  We'll chat on IRC.

Comment 81

[Axel Hecht [:Pike]]

Comment on attachment 465165 [details] [diff] [review]
hg diff output

I wouldn't be surprised if the ? is actually the utf-8 BOM.

Comment 82

[Seth Bindernagel]

Attachment: BBC Alba search plugin patch

Let's just use my patch from yesterday.  With an r=stas, we can check this in.  When doing so, please annotate the checkin with something like "Bug 560524: BBC-Alba searchplugin for gd. r=stas"

Comment 83

[Staś Małolepszy :stas]

Comment on attachment 465170 [details] [diff] [review]
BBC Alba search plugin patch

Looks good to me, thanks guys. This is ready to land then! :)

Comment 84

[Axel Hecht [:Pike]]

Oopsie, we landed this already, http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/gd/rev/dff4980f8af3, I did look at the patch in pastebin again, though.

Comment 85

[Staś Małolepszy :stas]

Oh, no problem :) Glad it's landed.

I think we can mark this bug as fixed now?

Comment 86

[Michael Bauer]

Yes, agreed.