560623 - New api method for the discovery pane: /api/list/top/...

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Jeff Balogh (:jbalogh)]

From the spec: 

This module lists the top 5 add-ons by average daily users over the past week. Add-ons shown in this list should always been compatible with the user's application, which means we should filter server-side and only send add-ons that are compatible with the application, OS, and browser version.

We do all this for list/featured, so sticking this in the api seems like the right way to go.

Comment 1

[Jeff Balogh (:jbalogh)]

It would be nice to work with JSON instead of XML here.

Comment 2

[Wil Clouser [:clouserw]]

(In reply to comment #1)
> It would be nice to work with JSON instead of XML here.

That's bug 543561 and, depending on how long it will take, shouldn't block this.  Davedash, can you estimate how long that would take?

Comment 3

[Jeff Balogh (:jbalogh)]

(In reply to comment #2)
> (In reply to comment #1)
> > It would be nice to work with JSON instead of XML here.
> 
> That's bug 543561 and, depending on how long it will take, shouldn't block
> this.

Right, it can't block this, but json would be really really nice.  I'm also planning to use /api/list/featured, so JSON all over would be good.

Comment 4

[Wil Clouser [:clouserw]]

(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > It would be nice to work with JSON instead of XML here.
> > 
> > That's bug 543561 and, depending on how long it will take, shouldn't block
> > this.
> 
> Right, it can't block this, but json would be really really nice.  I'm also
> planning to use /api/list/featured, so JSON all over would be good.

I want to use it for /top-tags too

Comment 5

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

I can get the /list/by_adu call tomorrow, and the JSON API before freeze, if not before the end of this week.

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

   470e893..114ac35  master -> master

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

What URLs should QA be testing, here?

Besides, that is:
https://preview.addons.mozilla.org/z/en-US/firefox/api/1.5/list/top
https://preview.addons.mozilla.org/z/en-US/firefox/api/1.5/list/featured
https://preview.addons.mozilla.org/z/en-US/firefox/api/1.5/list/top-tags

For QA: commit is http://github.com/jbalogh/zamboni/commit/114ac35.

Comment 8

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

api/1.5/list/by_adu/* <- this is that stupid format that we use for the other APIs

also for list api's you can tack on ?format=json

cheers

Comment 9

[Pratibha]

in-litmus+: https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=12081 : New api method for the discovery pane