Closed Bug 56065 Opened 24 years ago Closed 24 years ago

redundant filters added to filepicker for unknown content type

Categories

(SeaMonkey :: UI Design, defect, P3)

Product:
SeaMonkey
Component:
UI Design
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: bryner, Assigned: mscott)

Details

Attachments

(1 file)

patch
1.05 KB, patch
Details | Diff | Splinter Review 
In nsUnknownContentTypeHandler::PromptForSaveToFile, it appends "*.*" as a
filter if a suggested file extension couldn't be found.  This is unnecessary
since right after that, filterAll is appended.  So, there are two problems:

- two filters get added
- the *.* filter is not the correct "all files" filter on unix

I'm attaching a patch to only append a filter if we have a suggested extension.
 mscott, this appears to be from your checkin to
nsUnknownContentTypeHandler.cpp, rev. 1.33.
Attached patch patch — — Splinter Review 

    
    

    
  
ahh right you are. Good catch Brian. I messed that up. 

sr=mscott

    
    

    
  
*handing bryner some coffee*

    
    

    
  
checked in
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
QA Contact: sairuh → shrir

    
    

    
  
verified that the patch is in, marking as such. Also verified that the extra *.*
is not added. build:20001011604 trunk.
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: