Closed Bug 560815 Opened 14 years ago Closed 14 years ago

PRIVATE_TO_JSVAL(NULL) yields warning: NULL used in arithmetic with gcc 4.2.1

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5646) (dot 1)

In function ‘JSObject* js::ctypes::Library::Create(JSContext*, jsval)’:
js/src/ctypes/Library.cpp:91: warning: NULL used in arithmetic
In function ‘JSBool js::ctypes::Library::Close(JSContext*, uintN, jsval*)’:
js/src/ctypes/Library.cpp:197: warning: NULL used in arithmetic
Attached patch patchSplinter Review
Assignee: general → timeless
Status: NEW → ASSIGNED
Attachment #440467 - Flags: review?(jorendorff)
Comment on attachment 440467 [details] [diff] [review]
patch

p still needs to be parenthesized. I'll fix it before pushing.

I'll push this with my next batch of stuff (trees are METERED today, so look for it Monday).
Attachment #440467 - Flags: review?(jorendorff) → review+
http://hg.mozilla.org/mozilla-central/rev/450522cbb138
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: