Closed
Bug 561176
Opened 14 years ago
Closed 14 years ago
Restart dialog message is confusing
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1a3
People
(Reporter: mnyromyr, Assigned: ewong)
Details
Attachments
(1 file, 5 obsolete files)
2.56 KB,
patch
|
ewong
:
review+
ewong
:
superreview+
|
Details | Diff | Splinter Review |
After deinstalling an addon and clicking the "Restart SeaMonkey" button, a dialog (sheet) appears, saying: Restart SeaMonkey SeaMonkey will try to restore your tabs and windows when it restarts. [ ] Don not ask next time (Cancel) (Restart) It's totally unclear at first sight what (Cancel) will do here: 1. Will it cancel the restart? Then the buttons should say (Restart Later) (Restart Now). 2. Will it avoid tab/window restoration, but still restart? Then it should say (Restart without restoration) (Restart with restoration). Yes, I know it does (1), but we should definitely change the text. (Cancel) is almost always a bad alternative.
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → ewong
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: PowerPC → All
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #462377 -
Flags: review?(mnyromyr)
Reporter | ||
Comment 2•14 years ago
|
||
Comment on attachment 462377 [details] [diff] [review] Changed the Cancel button to Restart Later and the Restart button to Restart Now >-cancelTitle=&Cancel >+restartTitle=&Restart Now >+cancelTitle=Restart &Later Changing cancelTitle will also change the Cancel button for normal shutdown with multiple open tabs - "Restart Later" doesn't make much sense there. Most probably, you may need a new entity here like cancelRestartTitle etc. > neverAsk=Do not ask next time Maybe worth adding a suitable accesskey here as well, while you're at it. ;-)
Attachment #462377 -
Flags: review?(mnyromyr) → review-
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #2) > Comment on attachment 462377 [details] [diff] [review] > Changed the Cancel button to Restart Later and the Restart button to Restart > Now > > >-cancelTitle=&Cancel > >+restartTitle=&Restart Now > >+cancelTitle=Restart &Later > > Changing cancelTitle will also change the Cancel button for normal shutdown > with multiple open tabs - "Restart Later" doesn't make much sense there. Most > probably, you may need a new entity here like cancelRestartTitle etc. Yes. Silly me. I've done this type of thing before, so I should've guessed it wasn't that straight forward. I've done patch. Will include it now. > > > neverAsk=Do not ask next time > > Maybe worth adding a suitable accesskey here as well, while you're at it. ;-) Changed to &Do not ask...
Assignee | ||
Comment 4•14 years ago
|
||
Attachment #462377 -
Attachment is obsolete: true
Attachment #462634 -
Flags: review?(mnyromyr)
Reporter | ||
Comment 5•14 years ago
|
||
Comment on attachment 462634 [details] [diff] [review] Changed the Cancel button to Restart Later and the Restart button to Restart Now >diff --git a/suite/common/src/nsSuiteGlue.js b/suite/common/src/nsSuiteGlue.js > var button0Title, button2Title; > var button1Title = quitBundle.GetStringFromName("cancelTitle"); You're changing button1Title anyway below, no need to init it here. > var neverAskText = quitBundle.GetStringFromName("neverAsk"); > >- if (aQuitType == "restart") >+ if (aQuitType == "restart"){ Nit: space missing before {. >diff --git a/suite/locales/en-US/chrome/common/quitDialog.properties b/suite/locales/en-US/chrome/common/quitDialog.properties > quitTitle=&Quit > restartTitle=&Restart You forgot to change restartTitle. > cancelTitle=&Cancel >+cancelRestartTitle=Restart &Later r=me with those fixed; over to Neil... ;-)
Attachment #462634 -
Flags: superreview?(neil)
Attachment #462634 -
Flags: review?(mnyromyr)
Attachment #462634 -
Flags: review+
Assignee | ||
Comment 6•14 years ago
|
||
Attachment #462634 -
Attachment is obsolete: true
Attachment #463433 -
Flags: superreview?(neil)
Attachment #463433 -
Flags: review+
Attachment #462634 -
Flags: superreview?(neil)
Assignee | ||
Comment 7•14 years ago
|
||
Reordered the button1Title declaration.
Attachment #463433 -
Attachment is obsolete: true
Attachment #463435 -
Flags: superreview?(neil)
Attachment #463435 -
Flags: review+
Attachment #463433 -
Flags: superreview?(neil)
Assignee | ||
Updated•14 years ago
|
Attachment #463435 -
Attachment description: Changed the Cancel button to Restart Later and the Restart button to Restart Now → Changed the Cancel button to Restart Later and the Restart button to Restart Now v4
Comment 8•14 years ago
|
||
Comment on attachment 463435 [details] [diff] [review] Changed the Cancel button to Restart Later and the Restart button to Restart Now v4 > quitTitle=&Quit >-restartTitle=&Restart >+restartTitle=&Restart Now > cancelTitle=&Cancel >+cancelRestartTitle=Restart &Later > saveTitle=&Save and Quit >-neverAsk=Do not ask next time >+neverAsk=&Do not ask next time Sadly the l10n boys will be on us like a ton of bricks for doing this. So you'll need to use restartNowTitle and restartLaterTitle instead. While you're there you might as well put them before quitTitle. (The current order is completely wrong but we won't bother about that.)
Attachment #463435 -
Flags: superreview?(neil) → superreview-
Assignee | ||
Comment 9•14 years ago
|
||
(In reply to comment #8) > Comment on attachment 463435 [details] [diff] [review] > Changed the Cancel button to Restart Later and the Restart button to Restart > Now v4 > > > quitTitle=&Quit > >-restartTitle=&Restart > >+restartTitle=&Restart Now > > cancelTitle=&Cancel > >+cancelRestartTitle=Restart &Later > > saveTitle=&Save and Quit > >-neverAsk=Do not ask next time > >+neverAsk=&Do not ask next time > Sadly the l10n boys will be on us like a ton of bricks for doing this. > So you'll need to use restartNowTitle and restartLaterTitle instead. > While you're there you might as well put them before quitTitle. > (The current order is completely wrong but we won't bother about that.) I'm on it. When you mean the order is wrong, what order should it be? I might as well fix it while I'm at it.
Assignee | ||
Comment 10•14 years ago
|
||
Attachment #463435 -
Attachment is obsolete: true
Attachment #463542 -
Flags: superreview?(neil)
Comment 11•14 years ago
|
||
Comment on attachment 463542 [details] [diff] [review] Changed the Cancel button to Restart Later and the Restart button to Restart Now v5 > restartTitle=&Restart I don't think we need this one any more. sr=me with that fixed.
Attachment #463542 -
Flags: superreview?(neil) → superreview+
Assignee | ||
Comment 12•14 years ago
|
||
Removed the restart string.
Attachment #463542 -
Attachment is obsolete: true
Attachment #463739 -
Flags: superreview+
Attachment #463739 -
Flags: review+
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Comment 13•14 years ago
|
||
Comment on attachment 463739 [details] [diff] [review] Changed the Cancel button to Restart Later and the Restart button to Restart Now [Checkin: comment 13] http://hg.mozilla.org/comm-central/rev/7667f2321d07
Attachment #463739 -
Attachment description: Changed the Cancel button to Restart Later and the Restart button to Restart Now → Changed the Cancel button to Restart Later and the Restart button to Restart Now [Checkin: comment 13]
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a3
You need to log in
before you can comment on or make changes to this bug.
Description
•