561483 - Use jsctypes opaque struct types.

Status: RESOLVED WONTFIX

(Firefox :: Sync, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

NSS defines a few things as opaque structs, WeaveCrypto should use the new jsctypes support for this, for slightly better type-safety.

Also, I switched voidptr_t to void_t.ptr, since I prefer that syntax and it's been working for a while now.

Comment 1

[[e-mail]]

Comment on attachment 441186 [details] [diff] [review]
Patch v.1

r=dwitte!

Comment 2

[[e-mail]]

This can land now (or shortly, once tm merges to m-c).

Comment 3

[Mike Connor [:mconnor]]

Don't forget to make sure the component won't load on older builds without this support.

Comment 4

[Gregory Szorc [:gps]]

It's been more than a year since the review. Do we still want to land this?

Comment 5

[Mike Connor [:mconnor]]

I think if it's still applicable we want to land it! Does it apply cleanly-ish?

Comment 6

[Allison Naaktgeboren :ally]

sync triage: if still works, land it :)

Comment 7

[Yev]

How does this depend on block 743070, when that block shows it's depending on this to finish?

Comment 8

[Richard Newman [:rnewman]]

(In reply to Yev from comment #7)
> How does this depend on block 743070, when that block shows it's depending
> on this to finish?

Bug 743070 will render this bug, and others, unnecessary. If that bug is closed, then this can be, ergo depends on.

Comment 9

[Justin Dolske [:Dolske]]

I'm just going to call this wontfix -- WeaveCrypto really isn't under active development, and so this isn't worth the code churn.