561619 - JS CTypes has a build dependency bug

Status: RESOLVED FIXED

(Core :: js-ctypes, defect)

Description

[Robert Sayre]

Last night, I merged two perfectly green trees, TM and M-C, and got tons of CTypes crashes in jsdtoa.cpp.

After a clobber, it was all fine.

Comment 1

[Mike Moening]

Robert,

So are you saying that landing patch part 2 or bug# 549532 should be fine after a "clobber"? Please explain what a clobber is...Thanks.

Mike M.

Comment 2

[[e-mail]]

That is... very strange.

I'm not sure if I'll be able to tell anything from the logs, but I'll look.

Comment 3

[[e-mail]]

Confirmed. On a hunch I touched jsdtoa.h and rebuilt; the ctypes objects don't get remade.

I think the js/src/Makefile.in just needs more VPATH.

Comment 4

[[e-mail]]

(This also explains why I could never reproduce it in my local debugging. Yay dependency bugs!)

Comment 5

[[e-mail]]

Attachment: patch

This looks like it fixes it. Clobbering works; make clean && make works; touch jsdtoa.h && make works.

Tryserver's chewing on it now, to make sure it doesn't break any existing dep builds.

Comment 6

[[e-mail]]

Note that this will result in orphaned obj files in js/src/ctypes, but they're harmless and will be cleaned up on the next clobber.

Comment 7

[Robert Sayre]

(In reply to comment #1)
> Robert,
> 
> So are you saying that landing patch part 2 or bug# 549532 should be fine after
> a "clobber"? Please explain what a clobber is...Thanks.

A clobber is when we delete all existing object files and rebuild everything from scratch. Your patch just touched lots of files, so tickled this bug. After dwitte's fix lands, it should be clean.

Comment 8

[Mike Moening]

That explains why dtoa.c still crashed after backing out my patch.

Comment 9

[[e-mail]]

Comment on attachment 441388 [details] [diff] [review]
patch

http://hg.mozilla.org/tracemonkey/rev/2dde743568a0

Comment 10

[[e-mail]]

Pushed to tracemonkey.

Apologies to everyone who spent time looking at this; it went unfound for too long. I'm glad it was finally nailed down.

Comment 11

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/a56cf139176a