561655 - Save size of customization dialogs individually

Status: UNCONFIRMED

(Toolkit :: Toolbars and Toolbar Customization, enhancement)

Description

[Joachim Herb]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; de; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; de; rv:1.9.1.9) Gecko/20100317 Lightning/1.0b2pre Thunderbird/3.0.4 ID:20100317103207

At the moment, all customization dialogs, e.g. for the mail toolbar, the header pane toolbar (see bug 519956), the compose new message toolbar share the same size preference. They all overlay this code:
http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/customizeToolbar.xul#51
Here the width and height are made persistent.

This becomes a problem because the customization dialog should appear below the toolbar. Most toolbars are placed at the top of the window, so the customization dialogs can be quite large. But e.g. the header pane toolbar can be located in the middle of the window. If the opened customization dialog is larger then the available space below the toolbar, it is moved upward to fit on the window. But then it hides the toolbar. 

So there are different possible solutions:
- Save individual size information for each toolbar.
- Change the dialog size on opening when it is too large.


Reproducible: Always

Steps to Reproduce:
1. Open a customization dialog (e.g. for the main toolbar).
2. Change the width and height of the dialog and close it.
3. Choose another customization dialog, e.g. for the header pane dialog.

Actual Results:  
It opens with the size chosen before even if this means it has to be moved around the screen.

Expected Results:  
??? 
Either save dialog specific sizes or reduce the size of the dialog.

Comment 1

[Mark Banner (:standard8)]

Given the toolbar customisation code is in toolkit, this bug lives in that product as that's where we'd need the fix.

Comment 2

[Ronald Killmer]

I have been thinking about this pallet size and location issue for weeks. I may have a solution that could work.  

Basically it is a modification of the toolkit Js file that calculates the layout of the pallet window.  The change is use of variables in that file. Then the toolbar customize command that calls to toolkit for a pallet would pass a CSV string (height,width,x-position,y-position) to set the variables for the called instance of the pallet.

To get the desired persistence the strings could be added to prefs.js or into a theme jar. This would expose the strings to theme authors who want to skin the pallet.