Closed
Bug 561723
Opened 14 years ago
Closed 14 years ago
Port Bug 551505 [Fix context of RestoreDocument_proxy] to SeaMonkey
Categories
(SeaMonkey :: Session Restore, defect)
SeaMonkey
Session Restore
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1a1
People
(Reporter: misak.bugzilla, Assigned: misak.bugzilla)
References
Details
Attachments
(1 file)
|
5.88 KB,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
From parent bug: Right now RestoreDocument_proxy is added as a listener for the load event, so that it can refill form data. However it's added directly, as opposed to every other event listener adding SS and then calling a method. So the context is weird when looking at the code. `this` is not SessionStore, it's the browser object. This has worked fine, but in doing probing work for bug 550967, I needed access to the SessionStore `this`, but couldn't get it without creating a global or attaching it to the tab, which is hacky.
Attachment #441459 -
Flags: superreview?(neil)
Attachment #441459 -
Flags: review?(neil)
|
||
Updated•14 years ago
|
Attachment #441459 -
Flags: superreview?(neil)
Attachment #441459 -
Flags: superreview+
Attachment #441459 -
Flags: review?(neil)
Attachment #441459 -
Flags: review+
|
Assignee | |
Comment 1•14 years ago
|
||
Pushed: http://hg.mozilla.org/comm-central/rev/c0df81ab60c4
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•14 years ago
|
Target Milestone: --- → seamonkey2.1a1
You need to log in
before you can comment on or make changes to this bug.
Description
•