562031 - content.css can be loaded only for web content

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Platform patch

Should I ask a review to Boris or someone else?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 441804 [details] [diff] [review]
Patch

Why exactly do we want this patch? The BrowserStyleSheets component allows us
to apply the web theme to _any_ browser created in Fennec, not just our own.
One example is the reftest add-on.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #2)
> (From update of attachment 441804 [details] [diff] [review])
> Why exactly do we want this patch?

My plan was to clean up css to make it faster by removing the need to check "html *" each time. (I've read to much of https://developer.mozilla.org/en/Writing_Efficient_CSS)

> The BrowserStyleSheets component allows us
> to apply the web theme to _any_ browser created in Fennec, not just our own.
> One example is the reftest add-on.

Hmmm, I've forgot that.

We could probably get the same result with a few tweaks in this file after all. I think i'll open another bug for the platform patch.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 441806 [details] [diff] [review]
Platform patch

I've upload the platform patch to bug 403266.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 441804 [details] [diff] [review]
Patch

If you want to make some tweaks, that's OK, but I want to keep the component.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

I think this bug isn't needed anymore, right? If it is, REOPEN

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #6)
> I think this bug isn't needed anymore, right? If it is, REOPEN

thanks for closing it!