562144 - TM: make DTrace hooks pretty

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Chris Leary [:cdleary] (not checking bugmail)]

People seem unhappy with the amount of space that the dtrace hooks take up. I'd like to demonstrate that these hooks can be non-obtrusive and very useful, so I'm volunteering for another cleanup patch.

Comment 1

[Chris Leary [:cdleary] (not checking bugmail)]

Attachment: Prettify obtrusive DTrace stuff.

Leaves old interface in place for now.

Comment 2

[Robert Sayre]

Comment on attachment 441928 [details] [diff] [review]
Prettify obtrusive DTrace stuff.

this is a good first step, if we add systemtap or some windows probes, we should change the DTrace:: lines in the VM to Probe:: and allow different impls.

Comment 3

[Chris Leary [:cdleary] (not checking bugmail)]

Attachment: Prettify DTrace probes.

Patch update against trunk.

Comment 4

[Chris Leary [:cdleary] (not checking bugmail)]

Attachment: Arguments deletion fix and tests.

Whoops. For real this time.

Comment 5

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/tracemonkey/rev/12049657ec65

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/12049657ec65

Comment 7

[Justin Dolske [:Dolske]]

Hmm. I'm getting build failures on my 10.6 box with DTrace enabled...

Undefined symbols:
  "_jsdtrace_execute_done", referenced from:
      js::DTrace::ExecutionScope::endExecution()     in jsinvoke.o
  "_jsdtrace_object_finalize", referenced from:
      js::DTrace::finalizeObject(JSObject const*)in jsgc.o
  "_jsdtrace_function_return", referenced from:
      js::DTrace::exitJSFun(JSContext*, JSStackFrame*, JSFunction const*, long, long*)in jsinterp.o
      ...etc etc...

Comment 8

[Chris Leary [:cdleary] (not checking bugmail)]

(In reply to comment #7)
> Hmm. I'm getting build failures on my 10.6 box with DTrace enabled...

I see it too... should have a fix for this soon.