Closed
Bug 562289
Opened 14 years ago
Closed 13 years ago
Using a system proxy ignores socks_remote_dns pref
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
Details
Attachments
(1 file)
|
916 bytes,
patch
|
Biesinger
:
review+
|
Details | Diff | Splinter Review |
It looks like nsProtocolProxyService::Resolve_Internal never checks the value of mSOCKSProxyRemoteDNS when setting up a proxy.
|
Assignee | |
Comment 1•14 years ago
|
||
Tested this and it works fine. Not sure who to ask for a review on this.
|
|
Assignee | |
Updated•14 years ago
|
Attachment #442040 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•14 years ago
|
Component: Preferences → Networking
Product: Firefox → Core
QA Contact: preferences → networking
|
||
Updated•14 years ago
|
Attachment #442040 -
Flags: review?(bzbarsky) → review?(jduell.mcbugs)
|
|
||
Comment 2•14 years ago
|
||
Er, I meant to say: I don't really know this code. Jason, do you? Or do we need to get Christian or Honza to look at this?
|
||
Comment 3•14 years ago
|
||
Comment on attachment 442040 [details] [diff] [review] Fix I don't know SOCKS at all. Biesi, this is a one-liner--can you look?
Attachment #442040 -
Flags: review?(jduell.mcbugs) → review?(cbiesinger)
|
||
Comment 4•14 years ago
|
||
So... there is some discussion about this in https://bugzilla.mozilla.org/show_bug.cgi?id=134105#c53 and several following comments.
|
|
||
Comment 5•13 years ago
|
||
Comment on attachment 442040 [details] [diff] [review] Fix but I think this patch is a good idea.
Attachment #442040 -
Flags: review?(cbiesinger) → review+
|
|
||
Updated•13 years ago
|
Assignee: nobody → matt.woodrow
|
|
||
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 7•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6bbb0b61173d
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•