Closed
Bug 562545
Opened 14 years ago
Closed 14 years ago
Shift-reload keeps the scroll position stored
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: martijn.martijn, Assigned: vingtetun)
References
()
Details
(Whiteboard: [need-2.0-ver])
Attachments
(1 file, 1 obsolete file)
758 bytes,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
To reproduce: - Visit http://jquery.malsup.com/form/#ajaxForm - Scroll to the bottom of the page - Hit ctrl-shift-R Expected result: A complete reload, browser cache is bypassed, the scroll position is not restored. Actual result: A complete reload, browser cache is bypassed, but the scroll position is restored.
Reporter | ||
Comment 1•14 years ago
|
||
And it makes me wonder whether the zoom level should be remembered on a shift-reload.
Reporter | ||
Comment 2•14 years ago
|
||
Note to self: I added test for this in https://litmus.mozilla.org/show_test.cgi?id=9802
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #1) > And it makes me wonder whether the zoom level should be remembered on a > shift-reload. It looks like firefox keep it.
Assignee | ||
Comment 4•14 years ago
|
||
Low risk patch that affect a not very common use functionality.
Attachment #442381 -
Flags: review?(mark.finkle)
Reporter | ||
Comment 5•14 years ago
|
||
(In reply to comment #3) > (In reply to comment #1) > > And it makes me wonder whether the zoom level should be remembered on a > > shift-reload. > > It looks like firefox keep it. Yes, but in firefox, this is part of the site specific preferences. If you zoom in on a page, close Firefox, restart, then the zoom in is also remembered. The use case is for sites that consistently have small font sizes on their site, that some people have trouble reading. I think Fennec has a different kind of usage pattern, so you might want a different behavior there. Also zoom is not restored on back-forward in history, btw. Anyway, perhaps a new bug should be filed for this discussion?
Assignee | ||
Comment 6•14 years ago
|
||
(In reply to comment #5) > (In reply to comment #3) > > (In reply to comment #1) > > > And it makes me wonder whether the zoom level should be remembered on a > > > shift-reload. > > > > It looks like firefox keep it. > > Yes, but in firefox, this is part of the site specific preferences. If you zoom > in on a page, close Firefox, restart, then the zoom in is also remembered. The > use case is for sites that consistently have small font sizes on their site, > that some people have trouble reading. > I think Fennec has a different kind of usage pattern, so you might want a > different behavior there. Also zoom is not restored on back-forward in history, > btw. I'm agree that the use case is different, as an example because the screen is small you're _force_ to zoom to read the text of a website. You're probably right after all, but I would like to have Madhava's feedback on this behavior (though Ctrl+shift+R is _not_ a very large audience) > > Anyway, perhaps a new bug should be filed for this discussion? There is a start of a discussion about per domain zoom in bug 559838, but I won't mind implementing the correct behavior (in term of zoom) for Ctrl + shift + R in this bug.
Comment 7•14 years ago
|
||
I think that Shift-reload is a "completely reload the page / reset" function, so not going back to a new state is what we want. In other words, not remembering zoom level or position.
Assignee | ||
Comment 8•14 years ago
|
||
Assignee: nobody → 21
Attachment #442381 -
Attachment is obsolete: true
Attachment #442690 -
Flags: review?(mark.finkle)
Attachment #442381 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 9•14 years ago
|
||
Obviously the last patch address the zoom/scroll/everything case.
Updated•14 years ago
|
Attachment #442690 -
Flags: review?(mark.finkle) → review+
Comment 10•14 years ago
|
||
Nice clean patch pushed m-b: http://hg.mozilla.org/mobile-browser/rev/b0f738eaff02 shift-reload is not on m-1.1, so I am not pushing there.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 11•14 years ago
|
||
verified FIXED on build: Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.5pre) Gecko/20100503 Namoroka/3.6.5pre Fennec/1.1b2pre
Status: RESOLVED → VERIFIED
Flags: in-litmus+
Whiteboard: [need-2.0-ver]
Updated•14 years ago
|
OS: Windows 7 → All
Hardware: x86 → All
You need to log in
before you can comment on or make changes to this bug.
Description
•