562664 - Linux static build bustage with "undefined reference to mozilla::gfx::ConvertYCbCrToRGB32"

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Robert Kaiser]

It looks like we have one more unfixed bustage from bug 560147 which is visible on Thunderbird and SeaMonkey trees, and that's in Linux static builds.

Error message:

../../mozilla/staticlib/libthebes.a(BasicImages.o): In function `mozilla::layers::BasicPlanarYCbCrImage::SetData(mozilla::layers::PlanarYCbCrImage::Data const&)':
BasicImages.cpp:(.text+0x34a): undefined reference to `mozilla::gfx::ConvertYCbCrToRGB32(unsigned char const*, unsigned char const*, unsigned char const*, unsigned char*, int, int, int, int, int, int, int, mozilla::gfx::YUVType)'
collect2: ld returned 1 exit status
gmake[5]: *** [seamonkey-bin] Error 1

Example logs:

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1272532177.1272538047.7134.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1272552381.1272553494.10518.gz

Comment 1

[Mark Banner (:standard8)]

Note: my guess is that bug 562659 will fix this but I've not tried it out or looked in detail to be sure.

Comment 2

[Robert Kaiser]

It's possible that bug 562659 would solve this, but a fast fix here could go a different way as well, so I decided to file different bugs.

Comment 3

[Mark Banner (:standard8)]

Attachment: Possible fix

This is what Bas suggested to me on irc last night. Not perfect (i.e. bug 562659 would probably be better) but it may get us going again.

I've got this running on try server builds for Thunderbird + Firefox at the moment.

Comment 4

[Mark Banner (:standard8)]

I forgot, c-c try server can't do FF patches. Time to spin up a VM...

Comment 5

[Mark Banner (:standard8)]

Attachment: The fix

This patch applies correctly and fixes the issue on static Thunderbird, and doesn't appear to break Firefox builds. I'm still compiling shared Thunderbird, but I expect it'll be fine, hence putting up for review.

Comment 6

[Robert Kaiser]

With the patch, static and shared SeaMonkey (opt and debug for the latter), shared Thunderbird, and libxul Firefox compile fine for me on Linux! :)

Comment 7

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/mozilla-central/rev/d917796fa333