562708 - Folder preference for gloda indexing does not work for trash/junk/outbox folders (not retained)

Status: VERIFIED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Kent James (:rkent)]

Per http://getsatisfaction.com/mozilla_messaging/topics/search_trash_folder_with_new_index_search_in_tb3_howto there is demand for enabling gloda indexing on the trash folder. But when I tried the new folder preference (using a TB 3.1 nightly) it does not stick:

STR:

1) In folder pane, get the folder properties for the trash pane
2) check to enable "Include messages in this folder in Global search results"
3) press OK to save folder
4) display folder properties again

expected: "Include messages ... " is checked
actual: "Include messages ... " is not checked.

Comment 1

[Moreia]

I am definitely looking forward to seeing this *work*

Junk and Trash are two boxes where things wind up by accident sometimes. Having the option to search them is hugely valuable.

Comment 2

[Gary Oberbrunner]

This is also a problem for our users; they search for things and can't understand why Tbird can't find them even though other clients can.  Definitely need to be able to search in Trash at least!

Comment 3

[Mark Banner (:standard8)]

Andrew, any ideas what is going on where?

Comment 4

[Tim K]

Please add an option to support indexing of the Trash folders, even if it may need to be enabled through the config editor.

Comment 5

[Ludovic Hirlimann [:Usul]]

(In reply to comment #4)
> Please add an option to support indexing of the Trash folders, even if it may
> need to be enabled through the config editor.

Option is present right click on the trash and look into properties.

Comment 6

[Mark Banner (:standard8)]

Attachment: Proposed fix

There's two parts to this patch.

1) First there's a correction to the UI - the gloda checkbox wasn't being hidden when gloda was disabled or for the outbox.

Turns out that for the gloda disabled part the code was being hit, but then hideShowControls() was overriding the action. So I've moved that action above where the gloda overrides are done, and then I've added queue and newsgroup folder types to definitely make sure we disable on those.

2) resetFolderIndexingPriority was being called on a folder when the gloda box on the properties dialog was being checked. However, for Trash and Junk, this meant it was being rest to "never". I've therefore added a parameter to resetFolderIndexingPriority to allow indexing on special folders - i.e. if its the trash or junk it will be set to the default priority rather than never.

This then seems to work correctly for indexing if the user wants to enable it.

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 463550 [details] [diff] [review]
Proposed fix

sure

Comment 9

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/65708cb363ab

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 463550 [details] [diff] [review]
Proposed fix

We should consider this for 3.1.3.

Comment 11

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/releases/comm-1.9.2/rev/1caea43c3d03

Comment 12

[Wayne Mery (:wsmwk)]

I posted the link for 3.1.3pre in http://gsfn.us/t/nrge to get feedback

Comment 13

[Ludovic Hirlimann [:Usul]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.9) Gecko/20100825 Thunderbird/3.1.3