Closed
Bug 562884
Opened 14 years ago
Closed 14 years ago
Non-Firefox apps fail running test_fuel.js with "TypeError: AM_Cc['@mozilla.org/fuel/application;1'] is undefined"
Categories
(Toolkit :: Add-ons Manager, defect, P1)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla1.9.3a5
People
(Reporter: standard8, Assigned: mossop)
References
Details
(Whiteboard: [rewrite])
Attachments
(1 file)
1.31 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
Non-Firefox apps will fail when running test_fuel.js due to: /buildbot/linux-comm-central-check/build/objdir/mozilla/_tests/xpcshell/test_extensionmanager/xpcshell/test_fuel.js:51: TypeError: AM_Cc['@mozilla.org/fuel/application;1'] is undefined I can see several possibilities for fixes: - List each application in the test - Harmonise the different ids into one, so that each application used the same. - Move test_fuel.js under browser/ and maybe duplicate for each app. - Use the build system to generate a function to get the equivalent of fuel for each app.
Reporter | ||
Comment 2•14 years ago
|
||
(In reply to comment #1) > Mmh, is it a left-over from the patch on bug 552731? I wouldn't have said a left-over. Incorrect assumption in writing the test maybe.
Blocks: 552731
Assignee | ||
Comment 3•14 years ago
|
||
So FUEL isn't always present, when it is present does it sometimes have different contract IDs? I could probably look up the contract ID in the category manager registration for the Application global object and go from there.
Reporter | ||
Comment 4•14 years ago
|
||
Thunderbird's id is: "@mozilla.org/steel/application;1" SeaMonkey's id is: "@mozilla.org/smile/application;1"
Assignee | ||
Updated•14 years ago
|
Priority: -- → P1
Assignee | ||
Comment 5•14 years ago
|
||
This looks up the Application contract ID in the category manager and exits if it is not found or if whatever is there is not an extIApplication.
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #443687 -
Flags: review?(robert.bugzilla)
Assignee | ||
Updated•14 years ago
|
Flags: in-testsuite+
Flags: in-litmus-
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr][needs-review]
Updated•14 years ago
|
Attachment #443687 -
Flags: review?(robert.bugzilla) → review+
Updated•14 years ago
|
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite][fixed-in-addonsmgr][needs-landing]
Assignee | ||
Comment 6•14 years ago
|
||
http://hg.mozilla.org/projects/addonsmgr/rev/d2bf8e542e98
Assignee | ||
Comment 7•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/2a6fde3b2211
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-landing] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
Comment 8•14 years ago
|
||
Verified fixed by checkin and a green test-run.
Status: RESOLVED → VERIFIED
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•