563167 - TM: "Assertion failure: r == MONITOR_ERROR," with parse

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(function() {
  for (var a = 0; a < 2; a++) {
    parse("\uF002")
  }
})()

asserts js debug shell on TM tip with -j at Assertion failure: r == MONITOR_ERROR, at ../jsops.cpp:906

This still asserts even with the patch from bug 563120 applied.

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

autoBisect shows this is probably related to bug 560798:

The first bad revision is:
changeset:   41270:04b98e71bc55
user:        Luke Wagner
date:        Mon Apr 26 09:30:06 2010 -0700
summary:     Bug 560798 - propagate errors from deep-aborted natives (r=gal)

However, this patch might just merely have exposed the problem rather than cause it..

Comment 2

[Luke Wagner [:luke]]

Attachment: patch

This is the same type of error as bug 563120; this time its Parse() in shell/js.cpp.  Simple fix.

Comment 3

[Chris Leary [:cdleary] (not checking bugmail)]

Comment on attachment 442938 [details] [diff] [review]
patch

Schwoops. Thanks for the fix!

Comment 4

[Andreas Gal :gal]

++luke for aggressive assertions all over the place

Comment 5

[Luke Wagner [:luke]]

http://hg.mozilla.org/tracemonkey/rev/5ce433326103

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/5ce433326103