563191 - deprecated conversion from string constant to char* in nsAuthSambaNTLM::SpawnNTLMAuthHelper

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[timeless]

extensions/auth/nsAuthSambaNTLM.cpp: In member function ‘nsresult nsAuthSambaNTLM::SpawnNTLMAuthHelper()’:
nsAuthSambaNTLM.cpp:213:
 warning: deprecated conversion from string constant to ‘char*’
 warning: deprecated conversion from string constant to ‘char*’
 warning: deprecated conversion from string constant to ‘char*’
 warning: deprecated conversion from string constant to ‘char*’
 warning: deprecated conversion from string constant to ‘char*’

    char* args[] = {
        "ntlm_auth",
        "--helper-protocol", "ntlmssp-client-1",
        "--use-cached-creds",
        "--username", const_cast<char*>(username),
        nsnull
    };

this should be const char * const args[], however we can't do that today because the NSPR prototype isn't friendly (see blocker bug).

Comment 1

[timeless]

Attachment: patch

this can't be reviewed or pushed until the blocking bug is fixed.

Comment 4

[Zack Weinberg (:zwol)]

There is a patch in the blocking bug (bug 563192), which has gone unreviewed for over a year.  I have pinged it.  I don't know if there is anything else that can be done to get this unjammed.

Comment 5

[Joey Armstrong [:joey]]

(In reply to comment #4)
> There is a patch in the blocking bug (bug 563192), which has gone unreviewed
> for over a year.  I have pinged it.  I don't know if there is anything else
> that can be done to get this unjammed.

A few suggestions that were made:
  o poking people is good
  o finding component/module owners and poking them
  o and if important, poking product drivers
  o something to bring up at various triage meetings.
  - there are flags you can set that make it show up for various triage meetings as well.

Comment 6

[Cameron McCormack (:heycam)]

Attachment: patch 2

How about this instead?  (Saw this clang warning flying by and thought I'd grab it.)

Comment 7

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f14591911ad8

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f14591911ad8