563389 - Diff tool doesn't expand simple JAR file

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P4)

Description

[Jorge Villalobos [:jorgev] (he/him)]

This file diff isn't expanding the JAR file in this add-on:
https://addons.mozilla.org/en-US/firefox/files/diff/87631/
And the View Source tool does show the JAR contents:
https://addons.mozilla.org/en-US/firefox/files/browse/87631/1

There are only a handful of code files there, and they are all very simple, so I don't see how this could be causing a memory error. It may be a bug in the diff code then.

Comment 1

[Wil Clouser [:clouserw]]

The only .jar I found was chrome/chrome.jar so I assume that's what you're talking about, and this is working for me at both links.  Can you see if it's working for you now?

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

That's because the version was made public and the diff doesn't need to do this anymore.

I can still reproduce if I follow these steps:
1) Temporarily change the status of the latest version to pending review.
2) Open the diff page: https://addons.mozilla.org/en-US/firefox/files/diff/87631/
3) Try to open chrome.jar.

I haven't tested on preview because that version isn't present there, but it would be better to have it in preview instead of changing the status of the latest version back and forth.

Comment 3

[Wil Clouser [:clouserw]]

There is a check in the diff function that says "If the jar file doesn't exist in the previous version of the add-on, don't expand the jar file in the browser."

You're hitting that logic in this instance because the last "public" version of this add-on was in december and all the versions since have been "beta" which aren't checked against.

Comment 4

[Wil Clouser [:clouserw]]

-> 4.x for dev tools rewrite

Comment 5

[Wil Clouser [:clouserw]]

I assume this is fixed with the new tools.  -> andym to verify

Comment 6

[Andy McKay]

I wasn't expanding .jar's inside the files, will add.

Comment 7

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/0228a08265c533e9e2c3cba20007877202ddc291

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...