563414 - Excessive Line Wrapping at 1024x768

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Chris Howse [:chowse]]

Attachment: Examples

When browsing at 1024x768, several highly visible components on AMO are too wide to fit on a single line, and are wrapping in very sloppy ways (see attached screenshot).

Users browsing at 1024x768 still represent a significant portion of the population (see http://browsersize.googlelabs.com/), and with the rise of netbooks, this number is not diminishing.

Several of the most visible problem are also trivial fixes:

* In the promo, reduce the space between labels (i.e. Introduction, Shopping, Sports, ...).

* In the add-on directories, reduce space between the filtering/sorting options (i.e. Featured, Popular, ...).

* For add-on entries, remove the word 'reviews', use a more compact date format (e.g. YYYY/MM/DD), use an icon rather than 'weekly downloads', and remove the left margin around the description and metadata. (okay, maybe this wasn't trivial)

Comment 1

[[:Aleksej]]

Attachment: A piece of Russian text in "What are Add-ons?" doesn't fit.

A piece of Russian text in "What are Add-ons?" doesn't fit. It doesn't seem to be possible to shorten it enough to fit without loss of the sense and style.

Comment 2

[Chris Howse [:chowse]]

In the examples I cited above, the wrapping occurred not because a string was too long, but because there was excessive whitespace between several page elements. Eliminating these would be a trivial change, have no adverse effect on style or usability, and would make the page look more polished. This clearly won't address the problem for all locales, but it is an easy win for quite a few of them.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

We're using [amotestday] to denote bugs which come from the testday (not just ones we've re-confirmed).

Comment 4

[Chris Howse [:chowse]]

CSS fixes for most of the problems mentioned above:
http://github.com/chowse/zamboni/commit/cef132122698f8ee41003273075505d7de11225b

Comment 5

[Wil Clouser [:clouserw]]

Is this bug done?  If so, can we close it?

Comment 6

[Chris Howse [:chowse]]

Needs a pull into master. Jeff?

Comment 7

[Jeff Balogh (:jbalogh)]

http://github.com/jbalogh/zamboni/commits/a03f7dbfd

Comment 8

[[:Aleksej]]

(In reply to comment #1)
> Created an attachment (id=445387) [details]
> A piece of Russian text in "What are Add-ons?" doesn't fit.

Filed as bug 570673.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

We didn't do the last suggestion mentioned in comment 0; are we OK with that?  The rest looks good...

Comment 10

[Chris Howse [:chowse]]

I'm fine w/ punting on that. It's a much more complex change, and the line wrapping in the entry block looks less orphaned than the other cases.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot (1024x768)w

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED running 1024x768 on preview.AMO