563558 - inDOMView contentRemoved implementation doesn't take into account hidden whitespace nodes

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Colby Russell :crussell (no longer Mozilla-ing)]

Attachment: minimal test case

layout/inspector/src/inDOMView.cpp:965:
   if (container->GetChildCount() == 0) {
     // Fix up the parent
     parentNode->isContainer = PR_FALSE;
     parentNode->isOpen = PR_FALSE;
     mTree->InvalidateRow(NodeToRow(parentNode));
   }

Non-zero child count doesn't mean we're showing anything. If all of the children are ignorable whitespace, we need to update the parent row to no longer be a container.

1. Inspect the attached document, making sure "Show whitespace nodes" is off.
2. Open the BODY element
3. Delete the DIV

Note that the BODY element is still a container. You can even continue to toggle the open state, but there are no non-whitespace children to show.

Comment 1

[Colby Russell :crussell (no longer Mozilla-ing)]

Attachment: Check inDOMViewNode's previous and next pointers for visible rows

Shawn, can you review this? If not, any suggestions? Boris? Neil?

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 446132 [details] [diff] [review]
Check inDOMViewNode's previous and next pointers for visible rows

A layout peer is probably best, and this shouldn't need sr.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Instead of letting previousNode and nextNode hang around, which looks slightly dangerous here since we're deleting stuff, how about setting a PRBool "isOnlyChild" and then testing it below after deleting stuff?

Comment 4

[Colby Russell :crussell (no longer Mozilla-ing)]

Attachment: use an isOnlyChild PRBool instead of keeping pointers around

Comment 5

[Jonathan Kew [:jfkthame]]

http://hg.mozilla.org/mozilla-central/rev/a3eb83c7e386