564012 - Form helper can't navigate in nested frames

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, when clicking on the first text input, the form helper comes up.
But notice that you can't click on the "Next" button, which should be possible in that case.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Vivien, can you take a look?

Martijn, what real world use case?

Comment 2

[Martijn Wargers (dead)]

I didn't find this on a site, just during experimentation.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Tests is coming! :)

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch + tests

Patch + tests

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 445369 [details] [diff] [review]
Patch + tests

>diff -r 9772d862d2da chrome/content/browser-ui.js

>+  _getAllDocuments: function formHelper_getAllDocuments(aDocument, aResult) {
>+    /** Recursively find all documents, including root document. */

Remove this comment. The code tells the story pretty well.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/431478c437f1