564515 - migration wizard defaults to "do not sync" on fresh 2.0.0.24 profile

Status: VERIFIED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

1. create a fresh profile using Thunderbird 2.0.0.24
2. configure an IMAP account (I've been using my .Mac account)
3. exit Thunderbird 2
4. start a recent 1.9.2 build on that same profile (I've been using a self-built build form yesterday).
5. click "Next" in the migration wizard
6. "Do not synchronize" is the radiobutton selected.  "Synchronize" is what should be selected.

Comment 1

[Blake Winton (:bwinton) (:☕️)]

Attachment: Initial cut at the patch.

Yup, I think it's all pretty much contained in the patch.

Tested locally with a TB2 profile with a server's offline_download pref set to true, false, and left unset.

Later,
Blake.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Oh, and since this is related to profile migration we do at startup, I think it'll be a royal pain to test with Mozmill, which is most of why I didn't add Mozmill tests for it.  It should also be partially tested with bug 560741, although the relevant test there isn't failing for me, and I'm not quite sure why.  (Possibly because we test to see whether it's an nsIImapIncomingServer in Mozmill, thus triggering the fixed attribute access.)

Thanks,
Blake.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Pushed as:
http://hg.mozilla.org/comm-central/rev/e40e64d6ab6a
http://hg.mozilla.org/releases/comm-1.9.2/rev/562372248daa

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 444544 [details] [diff] [review]
Initial cut at the patch.

This affects 3.0 as well, because it took the patch from bug 562589.

Comment 5

[Mark Banner (:standard8)]

Landed on 1.9.1 (3.0.5 relbranch as well):

http://hg.mozilla.org/releases/comm-1.9.1/rev/8b36b51680a6
http://hg.mozilla.org/releases/comm-1.9.1/rev/c4b1d9c9fb5f

Comment 6

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: Screenshot with build 2

It now seems to be set to "synchronize" but I have _two_ migration assistants popping up in 3.0.5 build 2! (I only have 1 IMAP gmail account, nth10sd at gmail, and the default Local Folders from the TB 2.0.0.24 that I tested from)

Is this intended? (If it is, this can be verified)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.10) Gecko/20100512 Thunderbird/3.0.5

Comment 7

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: Screenshot with build 1

Here's a screenshot with build 1. Double migration assistant seems to be another bug (I haven't yet searched) but seems that this very bug was indeed fixed. Verifying.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.10) Gecko/20100510 Thunderbird/3.0.5