Closed
Bug 564574
Opened 14 years ago
Closed 14 years ago
[FIX]Pass the first appended node to ContentAppended
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
50.74 KB,
patch
|
jst
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
Callees can get it now using the index, but we'd like to remove the index. This bug is just about passing the node; updating callees to not use the index should happen in separate bugs.
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #444232 -
Flags: superreview?(jonas)
Attachment #444232 -
Flags: review?(jst)
Comment 2•14 years ago
|
||
Comment on attachment 444232 [details] [diff] [review] Like so - In nsXULDocument::ContentAppended(): // Update our element map PRUint32 count = aContainer->GetChildCount(); Looks like count is unused after this change. - In layout/svg/base/src/nsSVGEffects.cpp: nsSVGRenderingObserver::ContentAppended(nsIDocument *aDocument, nsIContent *aContainer, - PRInt32 aNewIndexInContainer) + nsIContent *aFirstNewContent, Remove the tabs that crept in here somehow... - In parser/html/nsHtml5PendingNotification.h: inline void Fire() { - nsNodeUtils::ContentAppended(mParent, mChildCount); + nsNodeUtils::ContentAppended(mParent, mParent->GetChildAt(mChildCount), + mChildCount); More tabs... r=jst with those minor issues fixed.
Attachment #444232 -
Flags: review?(jst) → review+
Comment on attachment 444232 [details] [diff] [review] Like so There are tabs in the new code in sSVGRenderingObserver::ContentAppended sr=me with that fixed
Attachment #444232 -
Flags: superreview?(jonas) → superreview+
Assignee | ||
Comment 4•14 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/3da93d131e35 with those changes.
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Assignee | ||
Updated•14 years ago
|
Target Milestone: --- → mozilla1.9.3a5
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•