Closed Bug 564936 Opened 14 years ago Closed 7 months ago

Make With objects non-native

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Version:
Other Branch
Type:
defect

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: jorendorff, Unassigned)

Details

I was shocked to discover today that With objects are native. Even mrbkap was surprised.

As with XML objects (see bug 560101 comment 8), With objects have a shape but do not support the shape guarantees. Fortunately they aren't exposed to scripts, and while they're on the scope chain the property cache and JIT are disabled. So no known correctness bug here, just general outrage.
With objects are so old there wasn't any notion of "non-native" -- no JSObjectOps, no LiveConnect, none of that.

But yeah: outrageous!

/be
Brendan, if we make with non-native we will have non-native objects on the scope chain. What gives?
What a predicament! Srsly, we could either make With non-native but tolerate it as a special case, or leave it native and do something stronger to defend against it being shapeless -- or could we keep it native and give it its proto's shape?

/be
Jason, aren't With objects empty in shape terms? Each with its own proto, the empty shape for a given With object must depend on proto identity.

/be
With objects never have any own properties, so I don't think it hurts if they are non-native.
Assignee: general → nobody
Severity: normal → S3
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.