Closed
Bug 565322
Opened 14 years ago
Closed 14 years ago
deadcode in nsOggReader::FindEndTime if !codecState
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity)
Attachments
(1 file)
|
794 bytes,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
793 PRInt64 nsOggReader::FindEndTime(PRInt64 aEndOffset)
892 if (!codecState) {
893 // This page is from a bitstream which we haven't encountered yet.
894 // It's probably from a new "link" in a "chained" ogg. Don't
895 // bother even trying to find a duration...
896 break;
899 PRInt64 t = codecState ? codecState->Time(granulepos) : -1;
|
||
Comment 2•14 years ago
|
||
Comment on attachment 444898 [details] [diff] [review] proposal Changed reviewer to cpearce as he is more familiar with the ogg seeking code.
Attachment #444898 -
Flags: review?(chris.double) → review?(chris)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 444898 [details] [diff] [review] proposal Thanks! The offending code is left over from when there was more debug logging in there, and should be removed.
Attachment #444898 -
Flags: review?(chris) → review+
http://hg.mozilla.org/mozilla-central/rev/84599af3f0c8
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•