56540 - Save Frame As... missing from File menu when viewing framed page, before clicking content

Status: VERIFIED WORKSFORME

(SeaMonkey :: UI Design, defect, P4)

Description

[sairuh (rarely reading bugmail)]

spun off of bug 21282. right now when you go to a page with frames, and look at
the File menu, there's only Save As... (ie, using a trunk build --if using a
branch build it says Save Page As...) the behavior of this issue differs btwn
platforms, so i might be seeing different bugs.

1. load the above URL, but don't click anywhere in the content.
2. dropdown the File menu. notice that only Save As...[or, Save Page As... if
you're using branch bits] is there.
3. click in any of the frames.

results:
a. on linux and winnt, Save Frame As... now appears in the File menu. in 4.x you
didn't have to make any of the frames active for the menu to show the right
thing.
b. on mac, nuthin' happens. Save Frame As... never appears in the File menu.
pink/jrgm, perhaps this is a menu bug? lemme know if it already exists...

Comment 1

[Blake Ross]

I'll investigate.  How did 4.x work if you didn't click in a frame first?  
Which frame would it save?  I think this pretty much depends on bug 42758, for 
the File menu at least -- we can put it in the context menu now because it's 
context-sensitive.

Comment 2

[sairuh (rarely reading bugmail)]

to clarify, Save Frame As is already in the context menu, on all platforms. one
less thing to worry about. :)

as for 4.x, this is what i see on winNT (using 4.7x):
1. load www.faqs.org
2. don't click in the content region, check the File menu first.
observation: both Save As and Save Frame As are greyed-out [disabled].
3. click anywhere in the content, check the File menu again.
observation: both Save As and Save Frame As are now enabled.

imho, the win32 4.x behavior seems the ideal behavior, because when you click a
particular frame, then select Save Frame As, it'll prompt you to save the frame
you had just clicked in.

<tangent type="related">
on linux there are Save Frame and Save Frameset which are always enabled (when
you're viewing a framed page), and on Mac there's only Save (disabled) and Save
As (enabled). then again, 4.x isn't xp --well, the menus in mozilla/6.0 aren't
xp either, but they have more in common (at least by content!) than 4.x...
trying to make 'em all work as i'd like (as in win32 4.x) might be more tricky
than i realize, of course.
</tangent>

Comment 3

[Matthew T (active 1999-2002)]

IMO it would it be better to have the option to save either the current frame or 
the whole frameset in the save dialog.

Comment 4

[Blake Ross]

that would be difficult since we're using native file dialogs on windows.

Don't want to fix this until 42758 is fixed.

Comment 5

[sairuh (rarely reading bugmail)]

hm...back on the trunk now, and this looks fixed on winnt and linux
[2000.11.21.08] --Save Frame As is now in the File menu, and works. however,
still a problem on mac [2000.11.21.13].

Comment 6

[Blake Ross]

passing back to Ben for now, I have some other stuff to worry about first.

Comment 7

[Viswanath Ramachandran]

nav triage team: reducing priority and accepting for nsbeta1. 

Comment 8

[Steve Dagley]

if this is accepted for nsbeta1 why is it targeted for future?  Clearing target.

Comment 9

[Marcia Knous [:marcia]]

nominating for dogfood (from sdagley's list of bugs that are good candidates for 
our next release) 

Comment 10

[ckritzer (gone)]

Seems to be there now.

On Build 2001-04-09-10-trunk MacOS

Comment 11

[sairuh (rarely reading bugmail)]

this is still a problem. tested on linux rh7.2 and winnt, using 2002.01.04.08,
and mac 10.1.2 w/2002.01.03.08.

Comment 12

[sairuh (rarely reading bugmail)]

i see the same results as originally reported.

to trudelle for triage.

is this a focus issue, perchance? also, should the mac issue be filed separately
since its behavior is somewhat different?

Comment 13

[Peter Trudelle]

I'm not sure the current Win32 behavior is defective.  On first going to the
page, should the focus be on a particular frame, or just the page?  Current
behavior seems to match IE6 as well.  Note that you don't have to click, you can
just hit tab to get into a frame.  Seems like this is related to accessibility,
adding keyword, cc aaronl.

I think the Mac problem does deserve its own bug report.

Comment 14

[Aaron Leventhal]

Bug 86931 is for automatically focusing the largest frame when a frameset loads.

Comment 15

[Peter Trudelle]

resolving as wfm

Comment 16

[sairuh (rarely reading bugmail)]

filed bug 122505 for the mac-specific issue in comment 12 and comment 13.