566283 - Rendering artifacts (extra borders/black,grey lines) around images at certain zoom levels

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect)

Description

[Nickolay_Ponomarev]

1. Load http://www.google.com/intl/en_ALL/images/srpr/logo1w.png
2. Check the image appearance at different zoom levels:

(number of zoom-ins/outs from 100% zoom)
-5 horizontal line below the image
-4 lines at the bottom and right of the image
-3 line at the right
-2 ok
-1 line at the bottom
100%  - ok
+1 ok
+2 line at the right
+3 ok
+4 right, bottom borders
+5 grey line at the bottom
+6 ok
+7 right,bottom
+8 ok

This happens only on Mac for me (Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a5pre) Gecko/20100516 Minefield/3.7a5pre)

This is a regression from bug 542605 (verified by backing out locally).

(and in case the build system failed me, testing with nightlies shows this regression range:
works: 2010-04-26-03  http://hg.mozilla.org/mozilla-central/rev/2968d19b0165
fail:  2010-04-27-03  http://hg.mozilla.org/mozilla-central/rev/29a6a85fab8e )

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

That regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2968d19b0165&tochange=29a6a85fab8e

The cairo update seems like the most likely cause, but there are a bunch of other possibilities.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Er, sorry, I missed the line in comment 0 that said this is confirmed to be a regression from the cairo update.

Comment 3

[Josh Aas]

Blocking 1.9.3 beta1, serious visual regression which is easy to reproduce.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

I believe this comes from EXTEND_NONE being fixed in the cairo quartz backend.
Switching to EXTEND_PAD could fix this.

Comment 6

[Joe Drew (not getting mail)]

Needs to hit _a_ beta, not necessarily _this_ beta.

Comment 7

[Jeremie Patonnier :Jeremie]

I confirm the bug on Linux With Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.3a6pre) Gecko/20100616 Minefield/3.7a6pre

But with some different behaviors:

(number of zoom-ins/outs from 100% zoom)
-5 ok
-4 lines at the bottom and right of the image
-3 line at the right
-2 ok
-1 line at the bottom
100%  - ok
+1 ok
+2 ok
+3 ok
+4 right, bottom borders
+5 ok
+6 ok
+7 ok
+8 ok

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Isn't this bug 567370 comment 0, or vice-versa?

Comment 9

[Oleg Romashin (:romaxa)]

this problem will be fixed after cairo update 562746...
Problem not reproducible with patch for next cairo update bug...

Current cairo is broken, and causing not only rendering problems but also stability issues like 569669

Comment 10

[Zack Weinberg (:zwol)]

See also bug 468496.

Comment 11

[Markus Stange [:mstange]]

I think this is exactly the problem mentioned in bug 418494 comment 4. Removing the optimization fixes the problem.

Comment 12

[Joe Drew (not getting mail)]

Attachment: use EXTEND_PAD on mac

Josh, if you can still reproduce this, can you apply this patch and see if it fixes the bug? It makes us use EXTEND_PAD correctly on OS X.

Comment 13

[Josh Aas]

Comment on attachment 497111 [details] [diff] [review]
use EXTEND_PAD on mac

I can't reproduce the problem on trunk and Mac OS X 10.6. I won't have access to a 10.5 box until next week.

Comment 14

[Nickolay_Ponomarev]

I can't reproduce on 10.5 with steps from comment 0 anymore...

Comment 15

[Zack Weinberg (:zwol)]

IMNSHO the patch should be applied even though the original problem is unreproducible, as it makes a special case go away.