566314 - Improve automation scripts and rewrite most of the MozmillWrapper class

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Automation, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Once all the refactoring work has happened on bug 565733 we will have to remove the MozmillWrapperCLI class which is a temporarily workaround for my Firefox automation scripts.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Well, bug 564537 should cover the refactoring work now.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With Mozmill 1.5.2 we should be able to remove the wrapper now. In the same step we have to rewrite all the scripts.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As it looks like right now we can't get rid of the wrapper class by using Mozmill 1.5.2. So I will refactor a lot of our existing code to make it better usable and to integrate some new features.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Clean-up wrapper class v1 [checked-in]

This patch mostly cleans up the wrapper class to align it better with Mozmill 1.5.2. It removes some unnecessary properties which can be directly set.

I don't want to move large portions of code around right now, but I will check in one of the next patches how to better align the wrapper to the API capabilities Mozmill 1.5.2 offers. Keep in mind the current implementation is from the very beginning.

Comment 6

[Jeff Hammel]

Note that bug 607111 is the "last" remaining change necessary to make inhereting from the CLI classes unnecessary (and, strictly speaking, nonsensical if you're using the e.g. MozMill class as an API).  This will be done for 2.0 and I'll get on it as soon as I clean up a few other bugs.

Comment 7

[Jeff Hammel]

Comment on attachment 519987 [details] [diff] [review]
Clean-up wrapper class v1 [checked-in]

This looks fine.  Wrapper mozmill will become much different -- and easier -- in 2.0, so probably anything done at the wrapper level shouldn't be a deep refactor for 1.5.2 since that will need to be done anyway for 2.0

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 519987 [details] [diff] [review]
Clean-up wrapper class v1 [checked-in]

Landed as:
http://hg.mozilla.org/qa/mozmill-automation/rev/e4f3af55bf9a

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

All remaining work now happens on bug 732134 and its dependencies.