Closed Bug 566507 Opened 14 years ago Closed 12 years ago

Review log out testcase

Categories

(Testing Graveyard :: WebQA, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: krupa.mozbugs, Unassigned)

Details

Attachments

(5 files)

Attached file verify User logout
Simple testcase to check Log out functionality.Uses AMOfunctions
Attachment #445859 - Flags: review?(vish.mozilla)
Attachment #445859 - Flags: review?(trumanwsmith)
Attachment #445859 - Flags: review?(stephen.donner)
Attachment #445859 - Flags: review?(mozbugs.retornam)
Attached file AMOfunctions
Attachment #445859 - Attachment mime type: text/html → text/x-python-script
the top most 'if' statement needs an else too.
if ret  == amo_fcns.functionPass:
    'some code'
else:
    unittest.fail('some msg')
Attached file Updated testcase
I made the changes you suggested.Thanks
Attachment #446041 - Flags: review?(vish.mozilla)
Attachment #446041 - Attachment mime type: text/html → text/x-python-script
My suggested code was pseudo-code (sorry for not making that clear).
The real code should look like
else:
    unittest.TestCase.fail('some msg')
Attachment #446083 - Flags: review?(vish.mozilla)
Attachment #445859 - Attachment mime type: text/x-python-script → text/plain
Attachment #445859 - Flags: review?(vish.mozilla) → review+
Attached patch Logout tc-05/20Splinter Review
Updated the formatting to match pep rules
Attachment #446632 - Flags: review?(vish.mozilla)
looks good. commit it.
Attachment #446632 - Flags: review?(vish.mozilla) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attachment #445859 - Attachment filename: verifyUserLogout.py → verifyUserLogout.py
Attachment #445859 - Flags: review?(trumanwsmith)
Attachment #445859 - Flags: review?(stephen.donner)
Attachment #445859 - Flags: review?(mozbugs.retornam)
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: