566692 - handle brackets in mxr searches to glimpse

Status: VERIFIED FIXED

(Webtools Graveyard :: MXR, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

I tried to search for 'input[type="file"]' and mxr seems to have choked on it.

Comment 1

[timeless]

thanks. it turns out that glimpse is at least a bit broken :(


[timeless@konigsberg mxr-test]$ /usr/local/bin/glimpse -i -H /data/mxr-data/mozilla-central -y -n -e 'input\[type="file"\]' 2>&1|head -5

/usr/local/bin/glimpse: unmatched '[', ']' (use \[, \] to search for [, ])
glimpse: error in searching index
Warning: pattern has words present in the stop-list: must SEARCH the files
/data/mxr-data/mozilla-central/mozilla-central/layout/style/contenteditable.css: 101: *|*:-moz-read-write > input[type="file"],
/data/mxr-data/mozilla-central/mozilla-central/layout/style/forms.css: 405: input[type="file"] {

So the "please file a bug links" came from those first 3 lines (which go to stderr)

Comment 2

[timeless]

http://hg.mozilla.org/webtools/mxr/rev/fe400cc13eee

Comment 3

[:Mook]

http://mxr.mozilla.org/mozilla/search?string=input[type%3D%22file%22]&case=1&find=css%24&tree=mozilla seems to produce results.  (The URL in the URL field took too long and gave me not results, so I limited it to CSS files.)

(timeless asked me to go around and verify a few fixed mxr bugs.)