Closed
Bug 566808
Opened 14 years ago
Closed 14 years ago
DeCOMtaminate nsIStyleRule method signatures
Categories
(Core :: CSS Parsing and Computation, defect, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: craig.topper, Assigned: craig.topper)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
40.79 KB,
patch
|
Details | Diff | Splinter Review |
nsIStyleRule contains two NSIMETHOD methods that always return NS_OK and their callers don't check the return value anyway. The should be converted to void to remove the returns. Patch coming soon.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #446171 -
Flags: review?(dbaron)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Oops found an include dependency in nsSVGElement.h cause by the removal of some includes in one of the CSS header files. I'll submit a new patch to fix after review.
Comment on attachment 446171 [details] [diff] [review] Patch to convert the two methods r=dbaron with the include changes However, note bug 239008 comment 29: it's probably better to avoid making changes right now that do anything invasive to nsCSSStyleRule and related classes (though this one should be fine, and trivial to merge with).
Attachment #446171 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Just needed to add a forward declaration.
Attachment #446171 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 5•14 years ago
|
||
Pushed as: http://hg.mozilla.org/mozilla-central/rev/9a7be1835b53
Depends on: 579614
No longer depends on: 579614
You need to log in
before you can comment on or make changes to this bug.
Description
•