Closed Bug 567013 Opened 14 years ago Closed 13 years ago

Please remove dead code interface: nsIBaseStream

Categories

(Core :: XPCOM, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: WeirdAl, Assigned: dzbarsky)

References

()

Details

Attachments

(1 file, 3 obsolete files)

      No description provided.
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
Attachment #551639 - Flags: review?(khuey)
Does this compile?  It looks like nsScriptableInputStream::Close is used ...
Attached patch Patch (obsolete) — Splinter Review
Attachment #551639 - Attachment is obsolete: true
Attachment #551642 - Flags: review?(khuey)
Attachment #551639 - Flags: review?(khuey)
Attached patch Patch that actually compiles (obsolete) — Splinter Review
Gah, the code was lying.
Attachment #551642 - Attachment is obsolete: true
Attachment #551644 - Flags: review?(khuey)
Attachment #551642 - Flags: review?(khuey)
Comment on attachment 551644 [details] [diff] [review]
Patch that actually compiles

I'm not really a peer, but this is easy enough.

r=me
Attachment #551644 - Flags: review?(khuey) → review+
Attached patch Patch r=khueySplinter Review
Attachment #551644 - Attachment is obsolete: true
Attachment #551854 - Flags: checkin?
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/863ba598a27b
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Attachment #551854 - Flags: checkin? → checkin+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: