567451 - Inline some hot paths

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

These show up in Shark profiles and really shouldn't...

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

Comment 2

[Boris Zbarsky [:bzbarsky]]

How about we just stick an mGlobalJSObject on nsIScriptGlobalObject, and make nsIScriptGlobalObject::GetGlobalJSObject inline and non-virtual?  Then we wouldn't need this "fast" method, right?

Comment 3

[Boris Zbarsky [:bzbarsky]]

(All that as a possible followup.)

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Yeah, I'd rather do that as a followup, especially because nsIScriptGlobalObject is supposed to be language agnostic...

Comment 5

[Robert Sayre]

(In reply to comment #4)
>
> nsIScriptGlobalObject is supposed to be language agnostic...

can we dispense with this agnosticism? it has ended up really costing us. At this point we have a lot platform that depends on JS anyway.

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

My only reservation about undoing that work is that we did sort of make a big deal of making it part of the platform at the time. This is a bigger question than can really be answered in this bug.

Comment 7

[Brendan Eich [:brendan]]

Mark, is the Python DOM stuff Working? Used? Owned? If none of the above, it is going to go. If two out of three we can talk. If one out of three, especially !Working but kinda-Used, then it's in trouble.

/be

Comment 8

[Boris Zbarsky [:bzbarsky]]

> especially because nsIScriptGlobalObject is supposed to be language agnostic

I'm not suggesting we remove the language-agnostic global object getter.  Just that we special-case the JS one, which we use extensively.

I would also be just fine with inlining the language-agnostic one on nsIScriptGlobalObject, honestly.

Comment 9

[Mark Hammond [:markh] [:mhammond]]

AFAIK, sadly Python DOM is languishing - no regular users I am aware of, and AFAIK I remain the default owner although haven't touched it for years now.

Comment 10

[Brendan Eich [:brendan]]

My hope with PyDOM was to get people using true Python (C-Python) in lieu of JS. But the problem is no other browser offers such a thing. IronPython in the DLR on Silverlight scripting the IE DOM -- not the same!

Mark, if you are ok with it (hg will remember), we will rip it out in an orderly fashion. We should have a newsgroup post about this. You game?

/be

Comment 11

[Brendan Eich [:brendan]]

Separate bug needed.

/be

Comment 12

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/tracemonkey/rev/0dab54516a5a

Comment 13

[Blake Kaplan (:mrbkap) (inactive)]

(In reply to comment #11)
> Separate bug needed.

bug 570738.

Comment 14

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/0dab54516a5a