Closed
Bug 567900
Opened 14 years ago
Closed 14 years ago
Enable JIT verbose output for release debugger builds
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rreitmai, Unassigned)
References
Details
(Whiteboard: fixed-in-tracemonkey, fixed-in-tamarin, fixed-in-nanojit)
Attachments
(1 file)
|
869 bytes,
patch
|
stejohns
:
review+
|
Details | Diff | Splinter Review |
Somewhere along the line -Dverbose=jit was disabled for all non-debug builds. This means that we can no longer see jit generated verbose output unless we build a debug build, which is very inconvenient. Also, the define NJ_VERBOSE_DISABLED was introduced without a corresponding ifdef around the JIT verbose flags of the shell which leads one to erroneously assume that methods are not being JIT'd (no output visible). As the verbose mechanism in the JIT adds less than 2% to overall size (measured on xcode built x86-32 shell) , recommend adding it back. If this is not acceptable (and/or we retain the NJ_VERBOSE_DISABLED define) then we need to fix the verbose flags parsing to report an error.
|
Reporter | |
Comment 1•14 years ago
|
||
Attachment #447225 -
Flags: review?(stejohns)
|
|
Reporter | |
Updated•14 years ago
|
Blocks: tamarin-debugging
|
||
Updated•14 years ago
|
Attachment #447225 -
Flags: review?(stejohns) → review+
|
|
Reporter | |
Comment 2•14 years ago
|
||
pushed http://hg.mozilla.org/tamarin-redux/rev/c26013c9f7df
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Comment 3•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/d43dc29cf8b4
Whiteboard: fixed-in-tracemonkey
|
|
Reporter | |
Updated•14 years ago
|
Whiteboard: fixed-in-tracemonkey → fixed-in-tracemonkey, fixed-in-tamarin, fixed-in-nanojit
You need to log in
before you can comment on or make changes to this bug.
Description
•