56794 - Add build logic for jarring component viewer chrome component on Mac

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Peter Van der Beken]

Ataching a patch and necessary files so component viewer gets jar'ed. Looking 
for review.

Comment 1

[Peter Van der Beken]

Attachment: Patch for build logic (mac/unix/win)

Comment 2

[Peter Van der Beken]

Attachment: mozilla/extensions/cview/jar.mn

Comment 3

[Peter Van der Beken]

Attachment: mozilla/extensions/cview/resources/content/contents.rdf

Comment 4

[Peter Van der Beken]

Attachment: mozilla/extensions/cview/resources/locale/en-US/contents.rdf

Comment 5

[Peter Van der Beken]

Attachment: mozilla/extensions/cview/resources/skin/contents.rdf

Comment 6

[cls]

In the makefiles, could you split up the REGCHROME calls into individual lines?
This has caused problems on OS/2 before.  Other than that, it looks good. r=cls

Comment 7

[Peter Van der Beken]

Attachment: New patch for build logic (mac/unix/win) - replaces 17232 Patch for build logic (mac/unix/win) Patch for build logic (mac/unix/win)

Comment 8

[Scott Collins]

Peter: have you built with this on Mac?  It looks good to me, but Mac build
changes are tricky and always require testing.  If you haven't built with this
change on Mac, then I'll have to before I can sr=.

Comment 9

[Peter Van der Beken]

Don't worry Scott, as Mac is my primary platform I always test there first. 
Thanks to both of you for quick response times.

Comment 10

[Peter Van der Beken]

Checked in.

Comment 11

[Axel Hecht]

Hey,
the checked in jar.mn has some errors, so I tried to fix those. I will attach
my jar.mn right after this. (some whitespace magic, don't know if it's tabs
or trailing whitespace)
I moved the jar.mn to the ressources directory, as that's the place where we
register the chrome, so there is only one dir to build the chrome.
Could somebody review the new jar.mn? I can only test on solaris.

Axel

Comment 12

[Axel Hecht]

Attachment: new extensions/cview/resources/jar.mn

Comment 13

[Jon Granrose]

this apparently broke the mac mozilla trunk verification build.  It started
failing with the 10/22 8pm builds with an error complaining about this jar.mn file.

this is a smoketest blocker.

Comment 14

[Peter Van der Beken]

Terribly sorry about that. Seems the file got the wrong line endings, not sure 
how that happened. I didn't see the build bustage last night.
You want to back out the change or should I make a patch that fixes this?

Comment 15

[Jon Granrose]

patch it and check it in please.

Comment 16

[Peter Van der Beken]

Fixing this involves checking in attachment 17767 [details] (new extensions/cview/
resources/jar.mn) and the following patch and removing the broken (and misplaced 
extensions/cview/jar.mn).

Comment 17

[Peter Van der Beken]

Attachment: patch for mac build logic

Comment 18

[Jon Granrose]

get it reviewd and check it in, a=granrose.

Comment 19

[Peter Van der Beken]

Looking for a review from Mac folks. This is a smoketest blocker. See comment at 
2000-10-23 10:00 for fix.

Comment 20

[Kathleen :Brade]

I'm testing this on my mac build now...

Comment 21

[Kathleen :Brade]

sorry; I only took the most recent patch so I need to retest again :-/

Comment 22

[Kathleen :Brade]

I have checked in the fix for the jar.mn file (attached 10/23/00 06:27)
I'm having problems with the 10/23/00 10:02 fix; it doesn't work at all for me 
(do we know that it is supposed to work or is this just a guess at a fix?)

Comment 23

[Peter Van der Beken]

Ok, I'm gonna check in the real fix. I have verified both debug and opt clobber 
in my tree. The file you fixed should have been removed, and checked in under 
its new path. The patch should then work.

Comment 24

[Peter Van der Beken]

Fix checked in. Watching Tinderbox before I mark fixed (it'll turn green, I 
promise).

Comment 25

[Peter Van der Beken]

Marking fixed.

Comment 26

[Jon Granrose]

verified.