568249 - Support geolocation on Android

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Comment 1

[Michael Wu [:mwu]]

Attachment: Add Geolocation provider for Android

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 447561 [details] [diff] [review]
Add Geolocation provider for Android

This is great!

>+#include "AndroidLocationProvider.h"
>+
>+using namespace mozilla;
Not sure why we need this.  If we do, fine.  If not, lets remove it


>diff --git a/widget/src/android/nsAppShell.cpp b/widget/src/android/nsAppShell.cpp

Is there a way to get notifications outside of the appshell?  This is the first example of having to use the app shell to get geo notifications.  If not, thats fine.

Comment 3

[Michael Wu [:mwu]]

(In reply to comment #2)
> >+#include "AndroidLocationProvider.h"
> >+
> >+using namespace mozilla;
> Not sure why we need this.  If we do, fine.  If not, lets remove it
> 
It's used so we don't have to do mozilla:: when using AndroidBridge.

> >diff --git a/widget/src/android/nsAppShell.cpp b/widget/src/android/nsAppShell.cpp
> 
> Is there a way to get notifications outside of the appshell?  This is the first
> example of having to use the app shell to get geo notifications.  If not, thats
> fine.
I think we could come up with other ways but this is the simplest way right now AFAICT.

Comment 4

[Michael Wu [:mwu]]

Attachment: As checked in

http://hg.mozilla.org/mozilla-central/rev/1bc9d134e4e9