Closed
Bug 568375
Opened 14 years ago
Closed 14 years ago
SpiderMonkey never generates JSOP_XMLOBJECT bytecode
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jimb, Assigned: jimb)
Details
(Whiteboard: [fixed-in-tracemonkey])
Attachments
(2 files)
1.67 KB,
patch
|
Details | Diff | Splinter Review | |
5.03 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
SpiderMonkey supports, but never generates, the JSOP_XMLOBJECT bytecode. By inspection of the code, there doesn't seem to be anything that generates JSOP_XMLOBJECT, and the attached patch, which adds 'JS_ASSERT(0)' calls to each point in the code that processes JSOP_XMLOBJECT bytecodes, causes no regressions. The bytecode should be deleted.
Comment 1•14 years ago
|
||
See the comment atop jsopcode.tbl for how to "remove" an op -- thanks for catching this one. /be
Assignee | ||
Updated•14 years ago
|
Assignee: general → jim
Assignee | ||
Comment 2•14 years ago
|
||
Attachment #450252 -
Flags: review?(jwalden+bmo)
Comment 3•14 years ago
|
||
Comment on attachment 450252 [details] [diff] [review] Delete the JSOP_XMLOBJECT bytecode. You also need to bump the bytecode version (see jsxdrapi.h, search for c0d3 I think), in case someone had ancient serialized code that used the opcode; r=me with that as well.
Attachment #450252 -
Flags: review?(jwalden+bmo) → review+
Assignee | ||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/9006396fcf1f
Status: NEW → ASSIGNED
Whiteboard: [fixed-in-tracemonkey]
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/9006396fcf1f
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•