Closed Bug 570138 Opened 14 years ago Closed 14 years ago

auto-config probing doesn't set smtp user name correctly

Categories

(Thunderbird :: Account Manager, defect)

x86
macOS
defect
Not set
normal

Tracking

(blocking-thunderbird3.1 rc2+, thunderbird3.1 rc2-fixed)

RESOLVED FIXED
Thunderbird 3.3a1
Tracking Status
blocking-thunderbird3.1 --- rc2+
thunderbird3.1 --- rc2-fixed

People

(Reporter: Bienvenu, Assigned: Bienvenu)

References

Details

Attachments

(1 file, 1 obsolete file)

On my dreamhost account, autoconfig is figuring out the user name correctly as being my e-mail address, but leaves the smtp server user name as just my name, so sending e-mail doesn't work. I suspect this is a regression, and it will cause a fair amount of support headache, since the user has to go change their smtp user name, which is very challenging for a lot of users.
Nominating, since it would be a shame to ship with this, and we know we're respinning for a few other bugs.
blocking-thunderbird3.1: --- → ?
Could this be a similar problem as seen in bug 568153?
Assignee: nobody → bienvenu
blocking-thunderbird3.1: ? → needed
Whiteboard: [needed RC2]
well, I didn't do an explicit retest, and I didn't notice this went wrong until the next day, because I didn't try to send a message from that profile until I was at the airport...I'll check.
Fixing the issue in bug 568153 doesn't seem to have any effect on this bug. And I don't see anything on the error console when I recreate this bug. I've completely forgotten how this code works, and it's probably been rewritten a couple times since I was involved, so it'll take me a little while to figure out what's going on here.
I verified that this is a regression from 3.0.4, just for a sanity check.
patch in bug 534604 regressed this, by ignoring the probed incoming user name when setting the outgoing server username.
Depends on: 534604
I suspect the way out is to distinguish between auto-probed usernames for incoming servers, and usernames determined by ispdata, and in the former case, make sure the newly created outgoing server uses the auto-probed username. I don't know how this information is propagated, however.
I don't think that information is propagated, but we could set a flag on the config indicating where it came from, if that made sense to you.

(And by "we", I mean "you".  ;)

Thanks,
Blake.
Attached patch proposed fix (obsolete) — Splinter Review
This fixes the bug for me. It shouldn't regress the regressing bug, because we shouldn't have to probe for ispdata configs. My one concern might be the case where the user has an existing smtp server configured, and is trying to set up a new incoming server, without a new smtp server. I'm not sure if that will cause us to crunch the existing smtp server. I rather doubt it, but I'll try it out.
Attachment #449486 - Flags: review?(bwinton)
bienvenu wrote:
> I suspect the way out is to distinguish between auto-probed usernames for
> incoming servers, and usernames determined by ispdata, and in the former case,
bwinton wrote:
> I don't think that information is propagated,

It is propagated, as config.source == AccountConfig.kSourceGuess or kSourceXML, see accountConfig.js.

r=BenB, without the first hunk. The first hunk is bug 568153.
ok, thx, Ben. I'll land this
Attachment #449486 - Attachment is obsolete: true
Attachment #449521 - Flags: review+
Attachment #449486 - Flags: review?(bwinton)
Attachment #449521 - Flags: approval-thunderbird3.1?
fixed on trunk - http://hg.mozilla.org/comm-central/pushloghtml?changeset=ddd853fb7773
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Attachment #449521 - Flags: approval-thunderbird3.1? → approval-thunderbird3.1+
fixed for comm-central 1.9.2
fix pushed for rc2
blocking-thunderbird3.1: needed → rc2+
Whiteboard: [needed RC2]
Target Milestone: --- → Thunderbird 3.2a1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: