570205 - IsTargetEditable could use isContentEditable

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

Currently IsTargetEditable works by looking for an HTML element with a non-inherit value of the contentEditable property. The new isContentEditable property does much the same thing, although we still have to find an HTML element; once we do find one we can then return its editableness directly.

Comment 1

[Edmund Wong (:ewong)]

Attachment: Changed the return to use IsContentEditable.

Comment 2

[[e-mail]]

Comment on attachment 449595 [details] [diff] [review]
Changed the return to use IsContentEditable.

>     for (var node = this.target; node; node = node.parentNode)
>       if (node instanceof Components.interfaces.nsIDOMNSHTMLElement)
>+         return node.isContentEditable;
[Nit: too much indentation. Please remove one space before checkin.]

Comment 3

[Edmund Wong (:ewong)]

Attachment: Changed the return to use IsContentEditable. [Checkin: comment 4]

Removed a space.

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 449612 [details] [diff] [review]
Changed the return to use IsContentEditable. [Checkin: comment 4]

http://hg.mozilla.org/comm-central/rev/a8b8bdb983aa