570321 - spell-check-dictionary name is not displayed in context menu

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Alice0775 White]

spell-check-dictionary name is not displayed in context menu.

Reproducible: Always

Steps to Reproduce:
1. Start Minfield/Namoroka with new profile
2. Right click on textarea
3. Chose "Languages >"

Actual Results:
 spell-check-dictionary name is not displayed in context menu

Expected Results:
 spell-check-dictionary name ishould be displayed in context menu

Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre) Gecko/20100603 Minefield/3.7a5pre ID:20100603110311

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=dc913bfadfd0&tochange=25442798da4a
Candidate bug:
Bug 433860  - No spelling suggestions for text inputs when contenteditable node in document

And Namoroka is also broken.
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.6pre) Gecko/20100605 Namoroka/3.6.6pre ID:20100605042233

But Shiretoko is fine.
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.11pre) Gecko/20100605 Firefox/3.5.11pre ID:20100605045013

Comment 1

[Alice0775 White]

It seems to be fixed the following modification for 
toolkit/content/InlineSpellChecker.jsm


-      item.label = displayName;
+      item.setAttribute("label", displayName);

Comment 2

[Alice0775 White]

And see forum http://forums.mozillazine.org/viewtopic.php?p=9458117#p9458117

Comment 3

[(mostly gone) XtC4UaLL [:xtc4uall]]

Alice, you learned how to create MQ based patches finally & thus can attach one for review?
btw, you rock! :-)

Comment 4

[(mostly gone) XtC4UaLL [:xtc4uall]]

while testing comment 0 (enabling 'check spelling', check for the languages, disabling 'check spelling') and writing comment 3 i crashed:

bp-afc49e3f-9a06-465b-944e-e10192100605
[@ nsTextServicesDocument::NodeHasOffsetEntry(nsTArray<OffsetEntry*>*, nsIDOMNode*, int*, int*) ]

Comment 5

[Alice0775 White]

(In reply to comment #3)
> Alice, you learned how to create MQ based patches finally & thus can attach one
> for review?
I think that it is difficult for me.

Comment 6

[(no longer active)]

(In reply to comment #4)
> while testing comment 0 (enabling 'check spelling', check for the languages,
> disabling 'check spelling') and writing comment 3 i crashed:
> 
> bp-afc49e3f-9a06-465b-944e-e10192100605
> [@ nsTextServicesDocument::NodeHasOffsetEntry(nsTArray<OffsetEntry*>*,
> nsIDOMNode*, int*, int*) ]

Filed bug 570350 for this crash.

Comment 7

[(no longer active)]

Attachment: Patch (v1)

OK, the problem is that when the menuitem is created, the XBL for it is not bound, so setting the property does not set the attribute on the item.  I originally did that because inside test_contextmenu.html, item.label would sometimes be undefined.  I figured out that we don't bind menuitem XBLs for items in menus which are not displayed, and that was the reason why item.label was sometimes undefined.  So I made the test use getAttribute as well, and all is good now.

Comment 8

[(no longer active)]

1.9.2.5 should come out with this patch, so that we don't ship a broken menu item to our users.

Comment 9

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/0ba3b3e08dfb

Comment 10

[alex_mayorga]

I can now see the spell-check-dicktionary name on Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a5pre) Gecko/20100610 Minefield/3.7a5pre ID:20100610035756

Comment 11

[LegNeato]

Comment on attachment 449497 [details] [diff] [review]
Patch (v1)

a=LegNeato for 1.9.2.6 and 1.9.1.11. Please land this on mozilla-1.9.2 default and mozilla-1.9.1 default.

Comment 12

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/1d878086b53b

Holding off on 1.9.1 landing until bug 433860 gets into 1.9.1.

Comment 13

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e889ceb68a15

Comment 14

[Gabriela [:gaby2300]]

I can't reproduce on 3.6.7