570417 - All content iterators need to take part in cycle collection

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

Bug 569504 made nsContentIterator participate in cycle collection.  We need to do the same for nsPreContentIterator and nsSubtreeContentIterator as well.

Given that nsPreContentIterator only exists to set mPre to true, I decided to remove that class and make NS_NewPreContentIterator set mPre to true instead.

I also filed bug 570416 to create a static analysis script which detects other similar cases.

Comment 1

[(no longer active)]

We also need this for branches.

Comment 2

[(no longer active)]

Attachment: Patch (v1)

Comment 3

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/961e152b8b7b

Comment 4

[(no longer active)]

Comment on attachment 449544 [details] [diff] [review]
Patch (v1)

This is the continuation of the work in bug 569504.

Comment 5

[LegNeato]

Comment on attachment 449544 [details] [diff] [review]
Patch (v1)

We will not be taking this for 3.6.6. Moving approval request forward.

If you disagree, send me an email.

Comment 6

[LegNeato]

Comment on attachment 449544 [details] [diff] [review]
Patch (v1)

a=LegNeato for 1.9.2.9 and 1.9.1.12

Comment 7

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/f5ebe00ac30b
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/2698ba315614