Closed
Bug 570455
Opened 14 years ago
Closed 14 years ago
Editor shouldn't do anything when ESC key is pressed because bug 471322 was marked as WONTFIX
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla2.0b1
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file)
|
5.48 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
See bug 471322, ESC keypress event should clear the latest text input. And then, the editor should consume the event. And see bug 569988, ESC key is also used for closing dialog boxes, so, we need to think whether the ESC key feature is really needed or not, first. Currently, nsHTMLEditor consume the ESC keypress event always. However, nsPlaintextEditor doesn't consume it always.
|
||
Comment 1•14 years ago
|
||
I think the behavior of the Esc key should be consistent across HTML and plain text editors. I don't think that there is any reason for us eat the Esc element if it doesn't do anything.
|
Assignee | |
Comment 2•14 years ago
|
||
This patch cleans up the ESC key handling.
|
|
Assignee | |
Updated•14 years ago
|
Summary: Esc keypress event should be consumed by editor only when it's used for clear → Editor shouldn't do anything when ESC key is pressed because bug 471322 is marked as WONTFIX
|
|
||
Updated•14 years ago
|
Attachment #451547 -
Flags: review?(ehsan) → review+
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 451547 [details] [diff] [review] Patch v1.0 Great, thanks!
|
|
Assignee | |
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/ba9bfb5a1bf6
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Summary: Editor shouldn't do anything when ESC key is pressed because bug 471322 is marked as WONTFIX → Editor shouldn't do anything when ESC key is pressed because bug 471322 was marked as WONTFIX
Target Milestone: --- → mozilla1.9.3a6
You need to log in
before you can comment on or make changes to this bug.
Description
•