570561 - dehydra: use JS_NewGlobalObject

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Ehren Metcalfe]

Attachment: patch

Need to switch JS_NewObject to JS_NewGlobalObject due to API change in bug 570040. Waiting on review until other SM issues have been straightened out.

Comment 1

[Ehren Metcalfe]

Attachment: patch

added JS_HAS_NEW_GLOBAL_OBJECT check (for old SpiderMonkey).

Comment 2

[(dormant account)]

Comment on attachment 449762 [details] [diff] [review]
patch

>diff --git a/dehydra.c b/dehydra.c
>--- a/dehydra.c
>+++ b/dehydra.c
>+static JSClass global_class = {
>+  "DehydraGlobal", /* name */
>+  JSCLASS_GLOBAL_FLAGS, /* flags */
>+  JS_PropertyStub, JS_PropertyStub, JS_PropertyStub, JS_PropertyStub,
>+  JS_EnumerateStub, JS_ResolveStub, JS_ConvertStub, JS_FinalizeStub,
>+  JSCLASS_NO_OPTIONAL_MEMBERS
>+};
>+

No need for a new stub class. Use js_ObjectClass

Comment 3

[Ehren Metcalfe]

isn't js_ObjectClass declared in jsobj.h? I can't include that because dehydra.c is compiled by cc.

Comment 4

[(dormant account)]

(In reply to comment #3)
> isn't js_ObjectClass declared in jsobj.h? I can't include that because
> dehydra.c is compiled by cc.

copy the extern declaration from the header? I see no need to declare another stub.

Comment 5

[Ehren Metcalfe]

kinda weird... nm reports js_ObjectClass is defined in both libjs_static.a and libmozjs.so but compiling this:

// blah.cpp
#include <jsapi.h>
#include <jsobj.h> // alternately, comment out and declare |extern JSClass js_ObjectClass;|

int main() {
  printf("%x\n", &js_ObjectClass);
}

g++ -I/home/ehren/SpiderMonkey/include/js/ -I/home/ehren/SpiderMonkey/lib blah.cpp

blah.cpp:(.text+0x5): undefined reference to `js_ObjectClass'

Comment 6

[(dormant account)]

If this is causing this much trouble, just use your original patch.

Comment 7

[[e-mail]]

It's not exported, so you can't use it.

Comment 8

[Ehren Metcalfe]

http://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/d55889f23932