571474 - [mozmill] Can't validate identity-icon-label with value "VeriSign, Inc. (US)" (testGreenLarry.js and testSecurityNotification.js)

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With Firefox 4 the country is displayed in its own label element. That's why we get the following failure when validating:

Could not validate element ID: identity-icon-label with value VeriSign, Inc. (US)'

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1.1 [checked-in]

testSecurityNotification is also affected. The test in that file is the same as the one we have in testGreenLarry. I removed it in favor of the latter test. Further I have changed the website to AMO which is a bit faster and will make lesser problems with updates.

Once we create a shared API for the security related functions we should also have a better method to extract information from the security certificate, i.e. city, state, and country. For now the changes will work.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed on default as:
http://hg.mozilla.org/qa/mozmill-tests/rev/b75137ff3919

I will come up with a patch for branch too.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1 (mozilla1.9.2/1) [checked-in]

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed on branches too:
http://hg.mozilla.org/qa/mozmill-tests/rev/04d466bf14fd
http://hg.mozilla.org/qa/mozmill-tests/rev/2d48e62c1e54

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The favicon check is still broken. I will work on a follow-up patch which will fix this specific item.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

http://brasstacks.mozilla.com/couchdb/mozmill/_design/reports/_show/report/9fd5d15275b511df9f76005056a533eb

Controller.assertProperty(ID: page-proxy-favicon) : https://addons.mozilla.org/media//img/favicon.ico == https://addons.mozilla.org/favicon.ico

We should simply check for the host instead of the full url. Could be similar to the issue we had with the favicon for Bugzilla.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Fix favicon url

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed follow-up on all branches:
http://hg.mozilla.org/qa/mozmill-tests/rev/dd74cbf7b0c3
http://hg.mozilla.org/qa/mozmill-tests/rev/1392424a9d25
http://hg.mozilla.org/qa/mozmill-tests/rev/8a7c71b29bb1

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.